Files
claude-code/src/components/TextInput.tsx
Bonerush 8ba51edec1 fix: 修复条件式 hook 调用导致的 "Rendered fewer hooks than expected" 错误
修复在 dev 模式下按下 Ctrl+O 切换 transcript 视图时 React 抛出
"Rendered fewer hooks than expected" 崩溃的问题。

## 根因分析

项目中有大量 hook(useState / useMemo / useRef / useSyncExternalStore 等)
被包裹在 `feature()` 三元表达式中条件调用,例如:

    const value = feature('X') ? useHook() : defaultValue;

在 build 模式下 `feature()` 是编译时常量,死代码消除会移除未使用的分支,
hooks 数量在编译后是确定的。但在 dev 模式下(scripts/dev.ts 注入
--feature 启用全部 31 个 feature),`feature()` 是运行时调用,
但始终返回 true,因此所有 hooks 都会被调用,原本不会出问题。

真正的触发器是 REPL.tsx 第 5381 行的提前返回:

    if (screen === 'transcript') { return transcriptReturn; }

当用户按下 Ctrl+O 进入 transcript 模式时,该提前返回之后的所有 hooks
(如 displayedAgentMessages 的 useMemo)都不会被调用,导致 React 在
下一次渲染时检测到 hooks 数量与上次不一致而崩溃。

此外,其他文件中也存在相同的条件式 hook 模式——虽然 dev 模式下
feature() 返回 true,所以这些路径实际上不会被触发,但它们是
潜在的隐患:若将来有人通过环境变量关闭某个 feature,
同样的崩溃会立即出现。

## 修复策略

采用统一模式:**始终无条件调用 hook,将 feature() gate 应用到值上**。

    // Before (unsafe — hook count varies by feature flag)
    const value = feature('X') ? useHook() : defaultValue;

    // After (safe — hook always called, gate on the value)
    const rawValue = useHook();
    const value = feature('X') ? rawValue : defaultValue;

## 修改清单

### 核心修复(REPL.tsx)
- 将 `displayedAgentMessages` useMemo 及依赖变量(viewedTask /
  viewedTeammateTask / viewedAgentTask / usesSyncMessages /
  rawAgentMessages / displayedMessages)从 transcript 提前返回
  之后移至之前,确保两模式下 hooks 调用顺序一致
- 修复 `disableMessageActions` / `useAssistantHistory` /
  `voiceIntegration` 的条件式 hook 调用

### 条件式 hook 修复(11 个文件)
- src/hooks/useGlobalKeybindings.tsx — isBriefOnly / toggleBrief
  keybinding 改为 isActive 门控
- src/hooks/useReplBridge.tsx — 5 个 BRIDGE_MODE 选值改为无条件调用
- src/hooks/useVoiceIntegration.tsx — 4 个 VOICE_MODE 选值修复
- src/components/PromptInput/Notifications.tsx — 4 个 feature 选值修复
- src/components/PromptInput/PromptInput.tsx — briefOwnsGap /
  companionSpeaking 修复
- src/components/PromptInput/PromptInputFooterLeftSide.tsx — 4 个
  VOICE_MODE 选值修复
- src/components/PromptInput/PromptInputQueuedCommands.tsx — isBriefOnly
- src/components/Spinner.tsx — briefEnvEnabled 修复
- src/components/TextInput.tsx — voiceState / audioLevels /
  animationFrame 修复
- src/components/messages/AttachmentMessage.tsx — isDemoEnv 修复
- src/components/messages/UserPromptMessage.tsx — isBriefOnly /
  viewingAgentTaskId / briefEnvEnabled 修复
- src/components/messages/UserToolResultMessage/UserToolSuccessMessage.tsx
  — isBriefOnly 修复

### 其他修复
- src/components/FeedbackSurvey/useFrustrationDetection.ts — 将 3 个
  提前返回合并为 shouldSkip 变量,handleTranscriptSelect 提前 return
- src/hooks/useIssueFlagBanner.ts — useRef 移到 USER_TYPE 检查之前
- src/hooks/useUpdateNotification.ts — useState 改为 useRef,
  避免版本号变化触发不必要重渲染

### 构建/开发配置
- build.ts — 添加 `sourcemap: 'linked'`
- scripts/dev.ts — NODE_ENV 从 'production' 改为 'development'

Closes #434
2026-05-08 13:17:25 +08:00

130 lines
5.3 KiB
TypeScript

import { feature } from 'bun:bundle';
import chalk from 'chalk';
import React, { useMemo, useRef } from 'react';
import { useVoiceState } from '../context/voice.js';
import { useClipboardImageHint } from '../hooks/useClipboardImageHint.js';
import { useSettings } from '../hooks/useSettings.js';
import { useTextInput } from '../hooks/useTextInput.js';
import { Box, color, useAnimationFrame, useTerminalFocus, useTheme } from '@anthropic/ink';
import type { BaseTextInputProps } from '../types/textInputTypes.js';
import { isEnvTruthy } from '../utils/envUtils.js';
import type { TextHighlight } from '../utils/textHighlighting.js';
import { BaseTextInput } from './BaseTextInput.js';
import { hueToRgb } from './Spinner/utils.js';
// Block characters for waveform bars: space (silent) + 8 rising block elements.
const BARS = ' \u2581\u2582\u2583\u2584\u2585\u2586\u2587\u2588';
// Mini waveform cursor width
const CURSOR_WAVEFORM_WIDTH = 1;
// Smoothing factor (0 = instant, 1 = frozen). Applied as EMA to
// smooth both rises and falls for a steady, non-jittery bar.
const SMOOTH = 0.7;
// Boost factor for audio levels — computeLevel normalizes with a
// conservative divisor (rms/2000), so normal speech sits around
// 0.3-0.5. This multiplier lets the bar use the full range.
const LEVEL_BOOST = 1.8;
// Raw audio level threshold (pre-boost) below which the cursor is
// grey. computeLevel returns sqrt(rms/2000), so ambient mic noise
// typically sits at 0.05-0.15. Speech starts around 0.2+.
const SILENCE_THRESHOLD = 0.15;
export type Props = BaseTextInputProps & {
highlights?: TextHighlight[];
};
export default function TextInput(props: Props): React.ReactNode {
const [theme] = useTheme();
const isTerminalFocused = useTerminalFocus();
// Hoisted to mount-time — this component re-renders on every keystroke.
const accessibilityEnabled = useMemo(() => isEnvTruthy(process.env.CLAUDE_CODE_ACCESSIBILITY), []);
const settings = useSettings();
const reducedMotion = settings.prefersReducedMotion ?? false;
const voiceStateRaw = useVoiceState(s => s.voiceState);
const voiceState = feature('VOICE_MODE') ? voiceStateRaw : ('idle' as const);
const isVoiceRecording = voiceState === 'recording';
const audioLevelsRaw = useVoiceState(s => s.voiceAudioLevels);
const audioLevels = feature('VOICE_MODE') ? audioLevelsRaw : [];
const smoothedRef = useRef<number[]>(new Array(CURSOR_WAVEFORM_WIDTH).fill(0));
const needsAnimation = isVoiceRecording && !reducedMotion;
const [animRefRaw, animTimeRaw] = useAnimationFrame(needsAnimation ? 50 : null);
const animRef = feature('VOICE_MODE') ? animRefRaw : () => {};
const animTime = feature('VOICE_MODE') ? animTimeRaw : 0;
// Show hint when terminal regains focus and clipboard has an image
useClipboardImageHint(isTerminalFocused, !!props.onImagePaste);
// Cursor invert function: mini waveform during voice recording,
// standard chalk.inverse otherwise. No warmup pulse — the ~120ms
// warmup window is too short for a 1s-period pulse to register, and
// driving TextInput re-renders at 50ms during warmup (while spaces
// are simultaneously arriving every 30-80ms) causes visible stutter.
const canShowCursor = isTerminalFocused && !accessibilityEnabled;
let invert: (text: string) => string;
if (!canShowCursor) {
invert = (text: string) => text;
} else if (isVoiceRecording && !reducedMotion) {
// Single-bar waveform from the latest audio level
const smoothed = smoothedRef.current;
const raw = audioLevels.length > 0 ? (audioLevels[audioLevels.length - 1] ?? 0) : 0;
const target = Math.min(raw * LEVEL_BOOST, 1);
smoothed[0] = (smoothed[0] ?? 0) * SMOOTH + target * (1 - SMOOTH);
const displayLevel = smoothed[0] ?? 0;
const barIndex = Math.max(1, Math.min(Math.round(displayLevel * (BARS.length - 1)), BARS.length - 1));
const isSilent = raw < SILENCE_THRESHOLD;
const hue = ((animTime / 1000) * 90) % 360;
const { r, g, b } = isSilent ? { r: 128, g: 128, b: 128 } : hueToRgb(hue);
invert = () => chalk.rgb(r, g, b)(BARS[barIndex]!);
} else {
invert = chalk.inverse;
}
const textInputState = useTextInput({
value: props.value,
onChange: props.onChange,
onSubmit: props.onSubmit,
onExit: props.onExit,
onExitMessage: props.onExitMessage,
onHistoryReset: props.onHistoryReset,
onHistoryUp: props.onHistoryUp,
onHistoryDown: props.onHistoryDown,
onClearInput: props.onClearInput,
focus: props.focus,
mask: props.mask,
multiline: props.multiline,
cursorChar: props.showCursor ? ' ' : '',
highlightPastedText: props.highlightPastedText,
invert,
themeText: color('text', theme),
columns: props.columns,
maxVisibleLines: props.maxVisibleLines,
onImagePaste: props.onImagePaste,
disableCursorMovementForUpDownKeys: props.disableCursorMovementForUpDownKeys,
disableEscapeDoublePress: props.disableEscapeDoublePress,
externalOffset: props.cursorOffset,
onOffsetChange: props.onChangeCursorOffset,
inputFilter: props.inputFilter,
inlineGhostText: props.inlineGhostText,
dim: chalk.dim,
});
return (
<Box ref={animRef}>
<BaseTextInput
inputState={textInputState}
terminalFocus={isTerminalFocused}
highlights={props.highlights}
invert={invert}
hidePlaceholderText={isVoiceRecording}
{...props}
/>
</Box>
);
}