mirror of
https://github.com/claude-code-best/claude-code.git
synced 2026-06-18 06:15:51 +00:00
Compare commits
3 Commits
feature/la
...
codex/memo
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
379928fa10 | ||
|
|
ee0d788e58 | ||
|
|
f353eb056a |
@@ -55,8 +55,6 @@ ccb update # 更新到最新版本
|
|||||||
CLAUDE_BRIDGE_BASE_URL=https://remote-control.claude-code-best.win/ CLAUDE_BRIDGE_OAUTH_TOKEN=test-my-key ccb --remote-control # 我们有自部署的远程控制
|
CLAUDE_BRIDGE_BASE_URL=https://remote-control.claude-code-best.win/ CLAUDE_BRIDGE_OAUTH_TOKEN=test-my-key ccb --remote-control # 我们有自部署的远程控制
|
||||||
```
|
```
|
||||||
|
|
||||||
> **安装/更新失败?** 先 `npm rm -g claude-code-best` 清理旧版本,再 `npm i -g claude-code-best@latest`。仍失败则指定版本号:`npm i -g claude-code-best@<版本号>`
|
|
||||||
|
|
||||||
## ⚡ 快速开始(源码版)
|
## ⚡ 快速开始(源码版)
|
||||||
|
|
||||||
### ⚙️ 环境要求
|
### ⚙️ 环境要求
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "claude-code-best",
|
"name": "claude-code-best",
|
||||||
"version": "1.10.4",
|
"version": "1.10.2",
|
||||||
"description": "Reverse-engineered Anthropic Claude Code CLI — interactive AI coding assistant in the terminal",
|
"description": "Reverse-engineered Anthropic Claude Code CLI — interactive AI coding assistant in the terminal",
|
||||||
"type": "module",
|
"type": "module",
|
||||||
"author": "claude-code-best <claude-code-best@proton.me>",
|
"author": "claude-code-best <claude-code-best@proton.me>",
|
||||||
|
|||||||
@@ -106,84 +106,6 @@ describe("findActualString", () => {
|
|||||||
const result = findActualString("hello", "");
|
const result = findActualString("hello", "");
|
||||||
expect(result).toBe("");
|
expect(result).toBe("");
|
||||||
});
|
});
|
||||||
|
|
||||||
// ── Tab/space normalization (Bug #2 reproduction) ──
|
|
||||||
|
|
||||||
test("finds match when search uses spaces but file uses tabs", () => {
|
|
||||||
// File content uses Tab indentation
|
|
||||||
const fileContent = "\tif (x) {\n\t\treturn 1;\n\t}";
|
|
||||||
// User copies from Read output which renders tabs as spaces
|
|
||||||
const searchWithSpaces = " if (x) {\n return 1;\n }";
|
|
||||||
const result = findActualString(fileContent, searchWithSpaces);
|
|
||||||
expect(result).not.toBeNull();
|
|
||||||
expect(result).toBe(fileContent);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("finds match when search mixes tabs and spaces inconsistently", () => {
|
|
||||||
const fileContent = "\tconst x = 1; // comment";
|
|
||||||
const searchMixed = " const x = 1; // comment";
|
|
||||||
const result = findActualString(fileContent, searchMixed);
|
|
||||||
expect(result).not.toBeNull();
|
|
||||||
});
|
|
||||||
|
|
||||||
test("finds match for single-line tab-to-space mismatch", () => {
|
|
||||||
const fileContent = "\t\torder_price = NormalizeDouble(ask, digits);";
|
|
||||||
const searchSpaces = " order_price = NormalizeDouble(ask, digits);";
|
|
||||||
const result = findActualString(fileContent, searchSpaces);
|
|
||||||
expect(result).not.toBeNull();
|
|
||||||
});
|
|
||||||
|
|
||||||
// ── CJK / UTF-8 characters (Bug #1 reproduction) ──
|
|
||||||
|
|
||||||
test("finds match with CJK characters in content", () => {
|
|
||||||
const fileContent = "input int x = 620; // 止盈点数(点) — 32个pip=320点";
|
|
||||||
const result = findActualString(fileContent, fileContent);
|
|
||||||
expect(result).toBe(fileContent);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("finds match with CJK characters when tab/space differs", () => {
|
|
||||||
const fileContent = "\t// 向上突破 → Sell Limit (逆方向做空)";
|
|
||||||
const searchSpaces = " // 向上突破 → Sell Limit (逆方向做空)";
|
|
||||||
const result = findActualString(fileContent, searchSpaces);
|
|
||||||
expect(result).not.toBeNull();
|
|
||||||
expect(result).toBe(fileContent);
|
|
||||||
});
|
|
||||||
|
|
||||||
// ── Multiline with tabs + CJK (combined Bug #1 + #2) ──
|
|
||||||
|
|
||||||
test("finds multiline match with tabs and CJK characters", () => {
|
|
||||||
const fileContent = "\tif(effective_dir == BREAKOUT_UP)\n\t\t{\n\t\t\t// 向上突破\n\t\t}";
|
|
||||||
const searchSpaces = " if(effective_dir == BREAKOUT_UP)\n {\n // 向上突破\n }";
|
|
||||||
const result = findActualString(fileContent, searchSpaces);
|
|
||||||
expect(result).not.toBeNull();
|
|
||||||
expect(result).toBe(fileContent);
|
|
||||||
});
|
|
||||||
|
|
||||||
// ── Returned string must be a valid substring of fileContent ──
|
|
||||||
|
|
||||||
test("returned string from tab match is a real substring of fileContent", () => {
|
|
||||||
const fileContent = "prefix\n\t\tindented code\nsuffix";
|
|
||||||
const searchSpaces = "prefix\n indented code\nsuffix";
|
|
||||||
const result = findActualString(fileContent, searchSpaces);
|
|
||||||
expect(result).not.toBeNull();
|
|
||||||
expect(fileContent.includes(result!)).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("returned string from partial tab match is a real substring", () => {
|
|
||||||
const fileContent = "line1\n\tif (x) {\n\t\tdoStuff();\n\t}\nline5";
|
|
||||||
const searchSpaces = " if (x) {\n doStuff();\n }";
|
|
||||||
const result = findActualString(fileContent, searchSpaces);
|
|
||||||
expect(result).not.toBeNull();
|
|
||||||
expect(fileContent.includes(result!)).toBe(true);
|
|
||||||
});
|
|
||||||
|
|
||||||
test("tab match with mixed indentation levels", () => {
|
|
||||||
const fileContent = "class Foo {\n\t\tmethod1() {\n\t\t\treturn 42;\n\t\t}\n}";
|
|
||||||
const searchSpaces = "class Foo {\n method1() {\n return 42;\n }\n}";
|
|
||||||
const result = findActualString(fileContent, searchSpaces);
|
|
||||||
expect(result).not.toBeNull();
|
|
||||||
expect(fileContent.includes(result!)).toBe(true);
|
|
||||||
});
|
|
||||||
});
|
});
|
||||||
|
|
||||||
// ─── preserveQuoteStyle ─────────────────────────────────────────────────
|
// ─── preserveQuoteStyle ─────────────────────────────────────────────────
|
||||||
|
|||||||
@@ -63,26 +63,9 @@ export function stripTrailingWhitespace(str: string): string {
|
|||||||
return result
|
return result
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* Normalizes whitespace for fuzzy matching by converting tabs to spaces
|
|
||||||
* and collapsing leading whitespace on each line to a canonical form.
|
|
||||||
* This handles the case where Read tool output renders tabs as spaces,
|
|
||||||
* so users copy spaces from the output but the file actually has tabs.
|
|
||||||
*/
|
|
||||||
function normalizeWhitespace(str: string): string {
|
|
||||||
return str.replace(/\t/g, ' ')
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Finds the actual string in the file content that matches the search string,
|
* Finds the actual string in the file content that matches the search string,
|
||||||
* accounting for quote normalization and tab/space differences.
|
* accounting for quote normalization
|
||||||
*
|
|
||||||
* Matching cascade:
|
|
||||||
* 1. Exact match
|
|
||||||
* 2. Quote normalization (curly → straight quotes)
|
|
||||||
* 3. Tab/space normalization (tabs ↔ spaces in leading whitespace)
|
|
||||||
* 4. Quote + tab/space normalization combined
|
|
||||||
*
|
|
||||||
* @param fileContent The file content to search in
|
* @param fileContent The file content to search in
|
||||||
* @param searchString The string to search for
|
* @param searchString The string to search for
|
||||||
* @returns The actual string found in the file, or null if not found
|
* @returns The actual string found in the file, or null if not found
|
||||||
@@ -106,92 +89,9 @@ export function findActualString(
|
|||||||
return fileContent.substring(searchIndex, searchIndex + searchString.length)
|
return fileContent.substring(searchIndex, searchIndex + searchString.length)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Try with tab/space normalization — handles the case where Read output
|
|
||||||
// renders tabs as spaces and the user copies the rendered version
|
|
||||||
const wsNormalizedFile = normalizeWhitespace(fileContent)
|
|
||||||
const wsNormalizedSearch = normalizeWhitespace(searchString)
|
|
||||||
|
|
||||||
const wsSearchIndex = wsNormalizedFile.indexOf(wsNormalizedSearch)
|
|
||||||
if (wsSearchIndex !== -1) {
|
|
||||||
// Map the match position back to the original file content.
|
|
||||||
// We need to find the corresponding range in the original string.
|
|
||||||
return mapNormalizedMatchBackToFile(fileContent, wsNormalizedFile, wsSearchIndex, wsNormalizedSearch.length)
|
|
||||||
}
|
|
||||||
|
|
||||||
// Try combined: quote normalization + tab/space normalization
|
|
||||||
const combinedFile = normalizeWhitespace(normalizedFile)
|
|
||||||
const combinedSearch = normalizeWhitespace(normalizedSearch)
|
|
||||||
|
|
||||||
const combinedIndex = combinedFile.indexOf(combinedSearch)
|
|
||||||
if (combinedIndex !== -1) {
|
|
||||||
return mapNormalizedMatchBackToFile(fileContent, combinedFile, combinedIndex, combinedSearch.length)
|
|
||||||
}
|
|
||||||
|
|
||||||
return null
|
return null
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* Given a match found in a normalized version of fileContent, map the match
|
|
||||||
* position back to the original fileContent and extract the corresponding
|
|
||||||
* substring.
|
|
||||||
*
|
|
||||||
* Strategy: walk through both strings character by character, building a
|
|
||||||
* mapping from normalized offset to original offset. When a tab is expanded
|
|
||||||
* to 4 spaces in the normalized version, the normalized offset advances by 4
|
|
||||||
* while the original offset advances by 1.
|
|
||||||
*/
|
|
||||||
function mapNormalizedMatchBackToFile(
|
|
||||||
fileContent: string,
|
|
||||||
normalizedFile: string,
|
|
||||||
normalizedStart: number,
|
|
||||||
normalizedLength: number,
|
|
||||||
): string {
|
|
||||||
// Build a sparse mapping from normalized position → original position.
|
|
||||||
// We only need to map the range [normalizedStart, normalizedStart + normalizedLength].
|
|
||||||
let normPos = 0
|
|
||||||
let origPos = 0
|
|
||||||
let origStart = -1
|
|
||||||
let origEnd = -1
|
|
||||||
|
|
||||||
while (origPos < fileContent.length && normPos <= normalizedStart + normalizedLength) {
|
|
||||||
if (normPos === normalizedStart) {
|
|
||||||
origStart = origPos
|
|
||||||
}
|
|
||||||
if (normPos === normalizedStart + normalizedLength) {
|
|
||||||
origEnd = origPos
|
|
||||||
break
|
|
||||||
}
|
|
||||||
|
|
||||||
const origChar = fileContent[origPos]!
|
|
||||||
if (origChar === '\t') {
|
|
||||||
// Tab expands to 4 spaces in normalized version
|
|
||||||
const nextNormPos = normPos + 4
|
|
||||||
// If normalizedStart falls within this expanded tab, snap to origPos
|
|
||||||
if (normPos < normalizedStart && nextNormPos > normalizedStart && origStart === -1) {
|
|
||||||
origStart = origPos
|
|
||||||
}
|
|
||||||
if (normPos < normalizedStart + normalizedLength && nextNormPos > normalizedStart + normalizedLength && origEnd === -1) {
|
|
||||||
origEnd = origPos + 1
|
|
||||||
}
|
|
||||||
normPos = nextNormPos
|
|
||||||
origPos++
|
|
||||||
} else {
|
|
||||||
normPos++
|
|
||||||
origPos++
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Fallback: if we couldn't map precisely, use character-count heuristic
|
|
||||||
if (origStart === -1) origStart = 0
|
|
||||||
if (origEnd === -1) {
|
|
||||||
// Approximate: use the ratio of original to normalized length
|
|
||||||
const ratio = fileContent.length / normalizedFile.length
|
|
||||||
origEnd = Math.round(origStart + normalizedLength * ratio)
|
|
||||||
}
|
|
||||||
|
|
||||||
return fileContent.substring(origStart, origEnd)
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* When old_string matched via quote normalization (curly quotes in file,
|
* When old_string matched via quote normalization (curly quotes in file,
|
||||||
* straight quotes from model), apply the same curly quote style to new_string
|
* straight quotes from model), apply the same curly quote style to new_string
|
||||||
|
|||||||
@@ -616,7 +616,10 @@ export const SendMessageTool: Tool<InputSchema, SendMessageToolOutput> =
|
|||||||
case 'shutdown_response':
|
case 'shutdown_response':
|
||||||
return `shutdown_response ${input.message.approve ? 'approve' : 'reject'} ${input.message.request_id}`
|
return `shutdown_response ${input.message.approve ? 'approve' : 'reject'} ${input.message.request_id}`
|
||||||
case 'plan_approval_response':
|
case 'plan_approval_response':
|
||||||
return `plan_approval ${input.message.approve ? 'approve' : 'reject'} to ${recipient}`
|
const planApprovalDecision = input.message.approve
|
||||||
|
? 'approve'
|
||||||
|
: 'reject'
|
||||||
|
return `plan_approval ${planApprovalDecision} to ${recipient}`
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
|
|
||||||
@@ -834,10 +837,10 @@ export const SendMessageTool: Tool<InputSchema, SendMessageToolOutput> =
|
|||||||
const { postInterClaudeMessage } =
|
const { postInterClaudeMessage } =
|
||||||
require('src/bridge/peerSessions.js') as typeof import('src/bridge/peerSessions.js')
|
require('src/bridge/peerSessions.js') as typeof import('src/bridge/peerSessions.js')
|
||||||
/* eslint-enable @typescript-eslint/no-require-imports */
|
/* eslint-enable @typescript-eslint/no-require-imports */
|
||||||
const result = (await postInterClaudeMessage(
|
const result = await postInterClaudeMessage(
|
||||||
addr.target,
|
addr.target,
|
||||||
input.message,
|
input.message,
|
||||||
)) as { ok: boolean; error?: string }
|
) as { ok: boolean; error?: string }
|
||||||
const preview = input.summary || truncate(input.message, 50)
|
const preview = input.summary || truncate(input.message, 50)
|
||||||
return {
|
return {
|
||||||
data: {
|
data: {
|
||||||
@@ -849,7 +852,6 @@ export const SendMessageTool: Tool<InputSchema, SendMessageToolOutput> =
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (addr.scheme === 'uds') {
|
if (addr.scheme === 'uds') {
|
||||||
const recipient = recipientForDisplay(input.to)
|
|
||||||
/* eslint-disable @typescript-eslint/no-require-imports */
|
/* eslint-disable @typescript-eslint/no-require-imports */
|
||||||
const { sendToUdsSocket } =
|
const { sendToUdsSocket } =
|
||||||
require('src/utils/udsClient.js') as typeof import('src/utils/udsClient.js')
|
require('src/utils/udsClient.js') as typeof import('src/utils/udsClient.js')
|
||||||
@@ -860,14 +862,14 @@ export const SendMessageTool: Tool<InputSchema, SendMessageToolOutput> =
|
|||||||
return {
|
return {
|
||||||
data: {
|
data: {
|
||||||
success: true,
|
success: true,
|
||||||
message: `”${preview}” → ${recipient}`,
|
message: `”${preview}” → ${input.to}`,
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
return {
|
return {
|
||||||
data: {
|
data: {
|
||||||
success: false,
|
success: false,
|
||||||
message: `Failed to send to ${recipient}: ${errorMessage(e)}`,
|
message: `Failed to send to ${input.to}: ${errorMessage(e)}`,
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -10,10 +10,6 @@ import {
|
|||||||
getOriginalCwd,
|
getOriginalCwd,
|
||||||
getSessionId,
|
getSessionId,
|
||||||
regenerateSessionId,
|
regenerateSessionId,
|
||||||
resetCostState,
|
|
||||||
setLastAPIRequest,
|
|
||||||
setLastAPIRequestMessages,
|
|
||||||
setLastClassifierRequests,
|
|
||||||
} from '../../bootstrap/state.js'
|
} from '../../bootstrap/state.js'
|
||||||
import type { SDKStatusMessage } from '../../entrypoints/sdk/coreTypes.js'
|
import type { SDKStatusMessage } from '../../entrypoints/sdk/coreTypes.js'
|
||||||
import {
|
import {
|
||||||
@@ -148,14 +144,6 @@ export async function clearConversation({
|
|||||||
// tracking) is retained so those agents keep functioning.
|
// tracking) is retained so those agents keep functioning.
|
||||||
clearSessionCaches(preservedAgentIds)
|
clearSessionCaches(preservedAgentIds)
|
||||||
|
|
||||||
// Clear large STATE-held data that outlives the message array.
|
|
||||||
// lastAPIRequestMessages can hold the full post-compaction conversation
|
|
||||||
// (hundreds of KB–MB) for /share; resetCostState clears modelUsage.
|
|
||||||
setLastAPIRequest(null)
|
|
||||||
setLastAPIRequestMessages(null)
|
|
||||||
setLastClassifierRequests(null)
|
|
||||||
resetCostState()
|
|
||||||
|
|
||||||
setCwd(getOriginalCwd())
|
setCwd(getOriginalCwd())
|
||||||
readFileState.clear()
|
readFileState.clear()
|
||||||
discoveredSkillNames?.clear()
|
discoveredSkillNames?.clear()
|
||||||
|
|||||||
@@ -77,8 +77,6 @@ export type Props = {
|
|||||||
lastThinkingBlockId?: string | null
|
lastThinkingBlockId?: string | null
|
||||||
/** UUID of the latest user bash output message (for auto-expanding) */
|
/** UUID of the latest user bash output message (for auto-expanding) */
|
||||||
latestBashOutputUUID?: string | null
|
latestBashOutputUUID?: string | null
|
||||||
/** Whether to collapse diff display for this message */
|
|
||||||
shouldCollapseDiffs?: boolean
|
|
||||||
}
|
}
|
||||||
|
|
||||||
function MessageImpl({
|
function MessageImpl({
|
||||||
@@ -101,7 +99,6 @@ function MessageImpl({
|
|||||||
isUserContinuation = false,
|
isUserContinuation = false,
|
||||||
lastThinkingBlockId,
|
lastThinkingBlockId,
|
||||||
latestBashOutputUUID,
|
latestBashOutputUUID,
|
||||||
shouldCollapseDiffs,
|
|
||||||
}: Props): React.ReactNode {
|
}: Props): React.ReactNode {
|
||||||
switch (message.type) {
|
switch (message.type) {
|
||||||
case 'attachment':
|
case 'attachment':
|
||||||
@@ -184,7 +181,6 @@ function MessageImpl({
|
|||||||
isUserContinuation={isUserContinuation}
|
isUserContinuation={isUserContinuation}
|
||||||
lookups={lookups}
|
lookups={lookups}
|
||||||
isTranscriptMode={isTranscriptMode}
|
isTranscriptMode={isTranscriptMode}
|
||||||
shouldCollapseDiffs={shouldCollapseDiffs}
|
|
||||||
/>
|
/>
|
||||||
))}
|
))}
|
||||||
</Box>
|
</Box>
|
||||||
@@ -297,7 +293,6 @@ function UserMessage({
|
|||||||
isUserContinuation,
|
isUserContinuation,
|
||||||
lookups,
|
lookups,
|
||||||
isTranscriptMode,
|
isTranscriptMode,
|
||||||
shouldCollapseDiffs,
|
|
||||||
}: {
|
}: {
|
||||||
message: NormalizedUserMessage
|
message: NormalizedUserMessage
|
||||||
addMargin: boolean
|
addMargin: boolean
|
||||||
@@ -314,7 +309,6 @@ function UserMessage({
|
|||||||
isUserContinuation: boolean
|
isUserContinuation: boolean
|
||||||
lookups: ReturnType<typeof buildMessageLookups>
|
lookups: ReturnType<typeof buildMessageLookups>
|
||||||
isTranscriptMode: boolean
|
isTranscriptMode: boolean
|
||||||
shouldCollapseDiffs?: boolean
|
|
||||||
}): React.ReactNode {
|
}): React.ReactNode {
|
||||||
const { columns } = useTerminalSize()
|
const { columns } = useTerminalSize()
|
||||||
switch (param.type) {
|
switch (param.type) {
|
||||||
@@ -350,7 +344,6 @@ function UserMessage({
|
|||||||
verbose={verbose}
|
verbose={verbose}
|
||||||
width={columns - 5}
|
width={columns - 5}
|
||||||
isTranscriptMode={isTranscriptMode}
|
isTranscriptMode={isTranscriptMode}
|
||||||
shouldCollapseDiffs={shouldCollapseDiffs}
|
|
||||||
/>
|
/>
|
||||||
)
|
)
|
||||||
default:
|
default:
|
||||||
|
|||||||
@@ -55,7 +55,6 @@ export type Props = {
|
|||||||
columns: number
|
columns: number
|
||||||
isLoading: boolean
|
isLoading: boolean
|
||||||
lookups: ReturnType<typeof buildMessageLookups>
|
lookups: ReturnType<typeof buildMessageLookups>
|
||||||
shouldCollapseDiffs?: boolean
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -142,7 +141,6 @@ function MessageRowImpl({
|
|||||||
columns,
|
columns,
|
||||||
isLoading,
|
isLoading,
|
||||||
lookups,
|
lookups,
|
||||||
shouldCollapseDiffs,
|
|
||||||
}: Props): React.ReactNode {
|
}: Props): React.ReactNode {
|
||||||
const isTranscriptMode = screen === 'transcript'
|
const isTranscriptMode = screen === 'transcript'
|
||||||
const isGrouped = msg.type === 'grouped_tool_use'
|
const isGrouped = msg.type === 'grouped_tool_use'
|
||||||
@@ -223,7 +221,6 @@ function MessageRowImpl({
|
|||||||
isUserContinuation={isUserContinuation}
|
isUserContinuation={isUserContinuation}
|
||||||
lastThinkingBlockId={lastThinkingBlockId}
|
lastThinkingBlockId={lastThinkingBlockId}
|
||||||
latestBashOutputUUID={latestBashOutputUUID}
|
latestBashOutputUUID={latestBashOutputUUID}
|
||||||
shouldCollapseDiffs={shouldCollapseDiffs}
|
|
||||||
/>
|
/>
|
||||||
)
|
)
|
||||||
// OffscreenFreeze: the outer React.memo already bails for static messages,
|
// OffscreenFreeze: the outer React.memo already bails for static messages,
|
||||||
|
|||||||
@@ -814,12 +814,6 @@ const MessagesImpl = ({
|
|||||||
streamingToolUseIDs,
|
streamingToolUseIDs,
|
||||||
))
|
))
|
||||||
|
|
||||||
// Collapse diffs for messages beyond the latest N messages.
|
|
||||||
// verbose (ctrl+o) overrides and always shows full diffs.
|
|
||||||
const DIFF_COLLAPSE_DISTANCE = 0
|
|
||||||
const shouldCollapseDiffs =
|
|
||||||
renderableMessages.length - 1 - index > DIFF_COLLAPSE_DISTANCE
|
|
||||||
|
|
||||||
const k = messageKey(msg)
|
const k = messageKey(msg)
|
||||||
const row = (
|
const row = (
|
||||||
<MessageRow
|
<MessageRow
|
||||||
@@ -844,7 +838,6 @@ const MessagesImpl = ({
|
|||||||
columns={columns}
|
columns={columns}
|
||||||
isLoading={isLoading}
|
isLoading={isLoading}
|
||||||
lookups={lookups}
|
lookups={lookups}
|
||||||
shouldCollapseDiffs={shouldCollapseDiffs}
|
|
||||||
/>
|
/>
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|||||||
@@ -27,7 +27,6 @@ type Props = {
|
|||||||
verbose: boolean
|
verbose: boolean
|
||||||
width: number | string
|
width: number | string
|
||||||
isTranscriptMode?: boolean
|
isTranscriptMode?: boolean
|
||||||
shouldCollapseDiffs?: boolean
|
|
||||||
}
|
}
|
||||||
|
|
||||||
export function UserToolResultMessage({
|
export function UserToolResultMessage({
|
||||||
@@ -40,7 +39,6 @@ export function UserToolResultMessage({
|
|||||||
verbose,
|
verbose,
|
||||||
width,
|
width,
|
||||||
isTranscriptMode,
|
isTranscriptMode,
|
||||||
shouldCollapseDiffs,
|
|
||||||
}: Props): React.ReactNode {
|
}: Props): React.ReactNode {
|
||||||
const toolUse = useGetToolFromMessages(param.tool_use_id, tools, lookups)
|
const toolUse = useGetToolFromMessages(param.tool_use_id, tools, lookups)
|
||||||
if (!toolUse) {
|
if (!toolUse) {
|
||||||
@@ -98,7 +96,6 @@ export function UserToolResultMessage({
|
|||||||
verbose={verbose}
|
verbose={verbose}
|
||||||
width={width}
|
width={width}
|
||||||
isTranscriptMode={isTranscriptMode}
|
isTranscriptMode={isTranscriptMode}
|
||||||
shouldCollapseDiffs={shouldCollapseDiffs}
|
|
||||||
/>
|
/>
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -33,7 +33,6 @@ type Props = {
|
|||||||
verbose: boolean
|
verbose: boolean
|
||||||
width: number | string
|
width: number | string
|
||||||
isTranscriptMode?: boolean
|
isTranscriptMode?: boolean
|
||||||
shouldCollapseDiffs?: boolean
|
|
||||||
}
|
}
|
||||||
|
|
||||||
export function UserToolSuccessMessage({
|
export function UserToolSuccessMessage({
|
||||||
@@ -47,7 +46,6 @@ export function UserToolSuccessMessage({
|
|||||||
verbose,
|
verbose,
|
||||||
width,
|
width,
|
||||||
isTranscriptMode,
|
isTranscriptMode,
|
||||||
shouldCollapseDiffs,
|
|
||||||
}: Props): React.ReactNode {
|
}: Props): React.ReactNode {
|
||||||
const [theme] = useTheme()
|
const [theme] = useTheme()
|
||||||
// Hook stays inside feature() ternary so external builds don't pay a
|
// Hook stays inside feature() ternary so external builds don't pay a
|
||||||
@@ -85,16 +83,12 @@ export function UserToolSuccessMessage({
|
|||||||
}
|
}
|
||||||
const toolResult = parsedOutput?.data ?? message.toolUseResult
|
const toolResult = parsedOutput?.data ?? message.toolUseResult
|
||||||
|
|
||||||
// Collapse diff display for old messages (verbose/ctrl+o overrides)
|
|
||||||
const effectiveStyle =
|
|
||||||
shouldCollapseDiffs && !verbose ? 'condensed' : style
|
|
||||||
|
|
||||||
const renderedMessage =
|
const renderedMessage =
|
||||||
tool.renderToolResultMessage?.(
|
tool.renderToolResultMessage?.(
|
||||||
toolResult as never,
|
toolResult as never,
|
||||||
filterToolProgressMessages(progressMessagesForMessage),
|
filterToolProgressMessages(progressMessagesForMessage),
|
||||||
{
|
{
|
||||||
style: effectiveStyle,
|
style,
|
||||||
theme,
|
theme,
|
||||||
tools,
|
tools,
|
||||||
verbose,
|
verbose,
|
||||||
|
|||||||
@@ -6907,9 +6907,6 @@ async function logTenguInit({
|
|||||||
allowDangerouslySkipPermissionsPassed,
|
allowDangerouslySkipPermissionsPassed,
|
||||||
thinkingType:
|
thinkingType:
|
||||||
thinkingConfig.type as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
thinkingConfig.type as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
||||||
...(thinkingConfig.type === "enabled" && {
|
|
||||||
thinkingBudgetTokens: thinkingConfig.budgetTokens,
|
|
||||||
}),
|
|
||||||
...(systemPromptFlag && {
|
...(systemPromptFlag && {
|
||||||
systemPromptFlag:
|
systemPromptFlag:
|
||||||
systemPromptFlag as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
systemPromptFlag as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
||||||
|
|||||||
@@ -3051,22 +3051,12 @@ export function REPL({
|
|||||||
// are O(n) per render, so drop everything before the previous
|
// are O(n) per render, so drop everything before the previous
|
||||||
// boundary to keep n bounded across multi-day sessions.
|
// boundary to keep n bounded across multi-day sessions.
|
||||||
if (isFullscreenEnvEnabled()) {
|
if (isFullscreenEnvEnabled()) {
|
||||||
setMessages(old => {
|
setMessages(old => [
|
||||||
const postBoundary = getMessagesAfterCompactBoundary(old, {
|
...getMessagesAfterCompactBoundary(old, {
|
||||||
includeSnipped: true,
|
includeSnipped: true,
|
||||||
})
|
}),
|
||||||
// Hard cap: keep at most 500 messages in fullscreen scrollback
|
newMessage,
|
||||||
// to prevent unbounded memory growth in multi-day sessions.
|
]);
|
||||||
// normalizeMessages/applyGrouping are O(n), and Ink fiber
|
|
||||||
// trees cost ~250KB RSS per message. Without this cap,
|
|
||||||
// scrollback after several compactions can reach thousands
|
|
||||||
// of messages (observed: 13k+, 1GB+ heap).
|
|
||||||
const MAX_FULLSCREEN_SCROLLBACK = 500
|
|
||||||
const kept = postBoundary.length > MAX_FULLSCREEN_SCROLLBACK
|
|
||||||
? postBoundary.slice(-MAX_FULLSCREEN_SCROLLBACK)
|
|
||||||
: postBoundary
|
|
||||||
return [...kept, newMessage]
|
|
||||||
});
|
|
||||||
} else {
|
} else {
|
||||||
setMessages(() => [newMessage]);
|
setMessages(() => [newMessage]);
|
||||||
}
|
}
|
||||||
@@ -3092,23 +3082,17 @@ export function REPL({
|
|||||||
// history). Replacing those leaves the AgentTool UI stuck at
|
// history). Replacing those leaves the AgentTool UI stuck at
|
||||||
// "Initializing…" because it renders the full progress trail.
|
// "Initializing…" because it renders the full progress trail.
|
||||||
setMessages(oldMessages => {
|
setMessages(oldMessages => {
|
||||||
|
const last = oldMessages.at(-1);
|
||||||
|
const lastData = last?.data as Record<string, unknown> | undefined;
|
||||||
const newData = newMessage.data as Record<string, unknown>;
|
const newData = newMessage.data as Record<string, unknown>;
|
||||||
// Scan backwards to find the last ephemeral progress with matching
|
if (
|
||||||
// parentToolUseID and type. Previously only checked the last message,
|
last?.type === 'progress' &&
|
||||||
// so interleaved non-ephemeral messages caused duplicate progress
|
last.parentToolUseID === newMessage.parentToolUseID &&
|
||||||
// entries to accumulate (observed 13k+ entries in sleep-heavy sessions).
|
lastData?.type === newData.type
|
||||||
for (let i = oldMessages.length - 1; i >= 0; i--) {
|
) {
|
||||||
const m = oldMessages[i]!
|
const copy = oldMessages.slice();
|
||||||
if (m.type !== 'progress') break
|
copy[copy.length - 1] = newMessage;
|
||||||
const mData = m.data as Record<string, unknown> | undefined
|
return copy;
|
||||||
if (
|
|
||||||
m.parentToolUseID === newMessage.parentToolUseID &&
|
|
||||||
mData?.type === newData.type
|
|
||||||
) {
|
|
||||||
const copy = oldMessages.slice();
|
|
||||||
copy[i] = newMessage;
|
|
||||||
return copy;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
return [...oldMessages, newMessage];
|
return [...oldMessages, newMessage];
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -5,7 +5,10 @@ import type {
|
|||||||
CacheSafeParams,
|
CacheSafeParams,
|
||||||
ForkedAgentResult,
|
ForkedAgentResult,
|
||||||
} from '../../../utils/forkedAgent.js'
|
} from '../../../utils/forkedAgent.js'
|
||||||
import { startAgentSummarization } from '../agentSummary.js'
|
import {
|
||||||
|
type AgentSummaryDependencies,
|
||||||
|
startAgentSummarization,
|
||||||
|
} from '../agentSummary.js'
|
||||||
|
|
||||||
const transcriptMessages = [
|
const transcriptMessages = [
|
||||||
{ type: 'user', message: { content: 'start' }, uuid: 'u1' },
|
{ type: 'user', message: { content: 'start' }, uuid: 'u1' },
|
||||||
@@ -27,17 +30,14 @@ describe('startAgentSummarization', () => {
|
|||||||
let forkCalls: ForkCall[]
|
let forkCalls: ForkCall[]
|
||||||
let updateCalls: Array<{ taskId: string; summary: string }>
|
let updateCalls: Array<{ taskId: string; summary: string }>
|
||||||
let transcriptMessagesForTest: Message[]
|
let transcriptMessagesForTest: Message[]
|
||||||
|
let debugLogs: string[]
|
||||||
|
let loggedErrors: Error[]
|
||||||
|
let clearedHandles: unknown[]
|
||||||
|
|
||||||
beforeEach(() => {
|
function startTestSummarization(
|
||||||
forkCalls = []
|
dependencies: AgentSummaryDependencies = {},
|
||||||
updateCalls = []
|
): { stop: () => void } {
|
||||||
scheduled = undefined
|
return startAgentSummarization(
|
||||||
handle = undefined
|
|
||||||
transcriptMessagesForTest = transcriptMessages
|
|
||||||
})
|
|
||||||
|
|
||||||
test('summarizes bounded transcript once and skips unchanged fingerprints', async () => {
|
|
||||||
handle = startAgentSummarization(
|
|
||||||
'task-1',
|
'task-1',
|
||||||
asAgentId('a0000000000000000'),
|
asAgentId('a0000000000000000'),
|
||||||
{
|
{
|
||||||
@@ -48,14 +48,22 @@ describe('startAgentSummarization', () => {
|
|||||||
} as unknown as CacheSafeParams,
|
} as unknown as CacheSafeParams,
|
||||||
() => undefined,
|
() => undefined,
|
||||||
{
|
{
|
||||||
clearTimeout: () => undefined,
|
clearTimeout: ((timeoutId: unknown) => {
|
||||||
|
clearedHandles.push(timeoutId)
|
||||||
|
}) as typeof clearTimeout,
|
||||||
getAgentTranscript: async () => ({
|
getAgentTranscript: async () => ({
|
||||||
messages: transcriptMessagesForTest,
|
messages: transcriptMessagesForTest,
|
||||||
contentReplacements: [],
|
contentReplacements: [],
|
||||||
}),
|
}),
|
||||||
isPoorModeActive: () => false,
|
isPoorModeActive: () => false,
|
||||||
logError: () => undefined,
|
logError: error => {
|
||||||
logForDebugging: () => undefined,
|
loggedErrors.push(
|
||||||
|
error instanceof Error ? error : new Error(String(error)),
|
||||||
|
)
|
||||||
|
},
|
||||||
|
logForDebugging: message => {
|
||||||
|
debugLogs.push(message)
|
||||||
|
},
|
||||||
runForkedAgent: async (args: ForkCall) => {
|
runForkedAgent: async (args: ForkCall) => {
|
||||||
forkCalls.push(args)
|
forkCalls.push(args)
|
||||||
return {
|
return {
|
||||||
@@ -79,8 +87,24 @@ describe('startAgentSummarization', () => {
|
|||||||
updateAgentSummary: (taskId: string, summary: string) => {
|
updateAgentSummary: (taskId: string, summary: string) => {
|
||||||
updateCalls.push({ taskId, summary })
|
updateCalls.push({ taskId, summary })
|
||||||
},
|
},
|
||||||
|
...dependencies,
|
||||||
},
|
},
|
||||||
)
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
forkCalls = []
|
||||||
|
updateCalls = []
|
||||||
|
scheduled = undefined
|
||||||
|
handle = undefined
|
||||||
|
transcriptMessagesForTest = transcriptMessages
|
||||||
|
debugLogs = []
|
||||||
|
loggedErrors = []
|
||||||
|
clearedHandles = []
|
||||||
|
})
|
||||||
|
|
||||||
|
test('summarizes bounded transcript once and skips unchanged fingerprints', async () => {
|
||||||
|
handle = startTestSummarization()
|
||||||
|
|
||||||
expect(typeof scheduled).toBe('function')
|
expect(typeof scheduled).toBe('function')
|
||||||
await scheduled!()
|
await scheduled!()
|
||||||
@@ -106,47 +130,83 @@ describe('startAgentSummarization', () => {
|
|||||||
expect(updateCalls).toHaveLength(1)
|
expect(updateCalls).toHaveLength(1)
|
||||||
})
|
})
|
||||||
|
|
||||||
test('skips summarization when bounded context is too small', async () => {
|
test('skips summarization when filtering leaves too little bounded context', async () => {
|
||||||
transcriptMessagesForTest = transcriptMessages.slice(0, 2)
|
transcriptMessagesForTest = [
|
||||||
|
{ type: 'user', message: { content: 'start' }, uuid: 'u1' },
|
||||||
handle = startAgentSummarization(
|
|
||||||
'task-1',
|
|
||||||
asAgentId('a0000000000000000'),
|
|
||||||
{
|
{
|
||||||
forkContextMessages: transcriptMessages,
|
type: 'assistant',
|
||||||
model: 'claude-test',
|
uuid: 'a1',
|
||||||
} as unknown as CacheSafeParams,
|
message: {
|
||||||
() => undefined,
|
content: [{ type: 'tool_use', id: 'missing', name: 'Read' }],
|
||||||
{
|
|
||||||
clearTimeout: () => undefined,
|
|
||||||
getAgentTranscript: async () => ({
|
|
||||||
messages: transcriptMessagesForTest,
|
|
||||||
contentReplacements: [],
|
|
||||||
}),
|
|
||||||
isPoorModeActive: () => false,
|
|
||||||
logError: () => undefined,
|
|
||||||
logForDebugging: () => undefined,
|
|
||||||
runForkedAgent: async (args: ForkCall) => {
|
|
||||||
forkCalls.push(args)
|
|
||||||
return { messages: [] } as unknown as ForkedAgentResult
|
|
||||||
},
|
|
||||||
setTimeout: ((callback: TimerHandler) => {
|
|
||||||
if (typeof callback !== 'function') {
|
|
||||||
throw new Error('Expected timer callback')
|
|
||||||
}
|
|
||||||
scheduled = callback as () => void | Promise<void>
|
|
||||||
return 1 as unknown as ReturnType<typeof setTimeout>
|
|
||||||
}) as unknown as typeof setTimeout,
|
|
||||||
updateAgentSummary: (taskId: string, summary: string) => {
|
|
||||||
updateCalls.push({ taskId, summary })
|
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
)
|
{ type: 'user', message: { content: 'continue' }, uuid: 'u2' },
|
||||||
|
] as unknown as Message[]
|
||||||
|
|
||||||
|
handle = startTestSummarization()
|
||||||
|
|
||||||
expect(typeof scheduled).toBe('function')
|
expect(typeof scheduled).toBe('function')
|
||||||
await scheduled!()
|
await scheduled!()
|
||||||
|
|
||||||
expect(forkCalls).toEqual([])
|
expect(forkCalls).toEqual([])
|
||||||
expect(updateCalls).toEqual([])
|
expect(updateCalls).toEqual([])
|
||||||
|
expect(debugLogs).toContain(
|
||||||
|
'[AgentSummary] Skipping summary for task-1: no bounded context available',
|
||||||
|
)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('skips summarization before building context when transcript is too short', async () => {
|
||||||
|
transcriptMessagesForTest = transcriptMessages.slice(0, 2)
|
||||||
|
handle = startTestSummarization()
|
||||||
|
|
||||||
|
expect(typeof scheduled).toBe('function')
|
||||||
|
await scheduled!()
|
||||||
|
|
||||||
|
expect(forkCalls).toEqual([])
|
||||||
|
expect(updateCalls).toEqual([])
|
||||||
|
expect(debugLogs).toContain(
|
||||||
|
'[AgentSummary] Skipping summary for task-1: not enough messages (2)',
|
||||||
|
)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('skips and reschedules while poor mode is active', async () => {
|
||||||
|
handle = startTestSummarization({
|
||||||
|
isPoorModeActive: () => true,
|
||||||
|
})
|
||||||
|
|
||||||
|
expect(typeof scheduled).toBe('function')
|
||||||
|
await scheduled!()
|
||||||
|
|
||||||
|
expect(forkCalls).toEqual([])
|
||||||
|
expect(updateCalls).toEqual([])
|
||||||
|
expect(debugLogs).toContain(
|
||||||
|
'[AgentSummary] Skipping summary — poor mode active',
|
||||||
|
)
|
||||||
|
})
|
||||||
|
|
||||||
|
test('logs summary errors and keeps the next timer owned by the summarizer', async () => {
|
||||||
|
const error = new Error('fork failed')
|
||||||
|
handle = startTestSummarization({
|
||||||
|
runForkedAgent: async () => {
|
||||||
|
throw error
|
||||||
|
},
|
||||||
|
})
|
||||||
|
|
||||||
|
expect(typeof scheduled).toBe('function')
|
||||||
|
await scheduled!()
|
||||||
|
|
||||||
|
expect(loggedErrors).toEqual([error])
|
||||||
|
expect(updateCalls).toEqual([])
|
||||||
|
})
|
||||||
|
|
||||||
|
test('stop clears the pending summary timer', () => {
|
||||||
|
handle = startTestSummarization()
|
||||||
|
|
||||||
|
handle.stop()
|
||||||
|
|
||||||
|
expect(debugLogs).toContain(
|
||||||
|
'[AgentSummary] Stopping summarization for task-1',
|
||||||
|
)
|
||||||
|
expect(clearedHandles).toEqual([1])
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -141,6 +141,13 @@ describe('getSummaryContextFingerprint', () => {
|
|||||||
expect(estimateMessageChars(message)).toBeGreaterThan(0)
|
expect(estimateMessageChars(message)).toBeGreaterThan(0)
|
||||||
})
|
})
|
||||||
|
|
||||||
|
test('treats unsupported top-level primitives as zero-size estimates', () => {
|
||||||
|
expect(
|
||||||
|
estimateMessageChars((() => undefined) as unknown as Message),
|
||||||
|
).toBe(0)
|
||||||
|
expect(estimateMessageChars(1n as unknown as Message)).toBe(0)
|
||||||
|
})
|
||||||
|
|
||||||
test('returns null for an empty transcript', () => {
|
test('returns null for an empty transcript', () => {
|
||||||
expect(getSummaryContextFingerprint([])).toBeNull()
|
expect(getSummaryContextFingerprint([])).toBeNull()
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -1776,10 +1776,6 @@ async function* queryModel(
|
|||||||
// captures only primitives instead of paramsFromContext's full closure scope
|
// captures only primitives instead of paramsFromContext's full closure scope
|
||||||
// (messagesForAPI, system, allTools, betas — the entire request-building
|
// (messagesForAPI, system, allTools, betas — the entire request-building
|
||||||
// context), which would otherwise be pinned until the promise resolves.
|
// context), which would otherwise be pinned until the promise resolves.
|
||||||
// Also capture thinking params for Langfuse observability.
|
|
||||||
// Pass the entire thinking config object so all fields (type, budget_tokens,
|
|
||||||
// and any future additions) flow through without cherry-picking.
|
|
||||||
let langfuseThinking: BetaMessageStreamParams['thinking'] | undefined
|
|
||||||
{
|
{
|
||||||
const queryParams = paramsFromContext({
|
const queryParams = paramsFromContext({
|
||||||
model: options.model,
|
model: options.model,
|
||||||
@@ -1787,10 +1783,8 @@ async function* queryModel(
|
|||||||
})
|
})
|
||||||
const logMessagesLength = queryParams.messages.length
|
const logMessagesLength = queryParams.messages.length
|
||||||
const logBetas = useBetas ? (queryParams.betas ?? []) : []
|
const logBetas = useBetas ? (queryParams.betas ?? []) : []
|
||||||
|
const logThinkingType = queryParams.thinking?.type ?? 'disabled'
|
||||||
const logEffortValue = queryParams.output_config?.effort
|
const logEffortValue = queryParams.output_config?.effort
|
||||||
if (queryParams.thinking && queryParams.thinking.type !== 'disabled') {
|
|
||||||
langfuseThinking = queryParams.thinking
|
|
||||||
}
|
|
||||||
void options.getToolPermissionContext().then(permissionContext => {
|
void options.getToolPermissionContext().then(permissionContext => {
|
||||||
logAPIQuery({
|
logAPIQuery({
|
||||||
model: options.model,
|
model: options.model,
|
||||||
@@ -1800,7 +1794,7 @@ async function* queryModel(
|
|||||||
permissionMode: permissionContext.mode,
|
permissionMode: permissionContext.mode,
|
||||||
querySource: options.querySource,
|
querySource: options.querySource,
|
||||||
queryTracking: options.queryTracking,
|
queryTracking: options.queryTracking,
|
||||||
thinkingConfig,
|
thinkingType: logThinkingType,
|
||||||
effortValue: logEffortValue,
|
effortValue: logEffortValue,
|
||||||
fastMode: isFastMode,
|
fastMode: isFastMode,
|
||||||
previousRequestId,
|
previousRequestId,
|
||||||
@@ -2551,9 +2545,6 @@ async function* queryModel(
|
|||||||
maxOutputTokens,
|
maxOutputTokens,
|
||||||
thinkingType:
|
thinkingType:
|
||||||
thinkingConfig.type as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
thinkingConfig.type as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
||||||
...(thinkingConfig.type === 'enabled' && {
|
|
||||||
thinkingBudgetTokens: thinkingConfig.budgetTokens,
|
|
||||||
}),
|
|
||||||
fallback_disabled: true,
|
fallback_disabled: true,
|
||||||
request_id: (streamRequestId ??
|
request_id: (streamRequestId ??
|
||||||
'unknown') as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
'unknown') as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
||||||
@@ -2586,9 +2577,6 @@ async function* queryModel(
|
|||||||
maxOutputTokens,
|
maxOutputTokens,
|
||||||
thinkingType:
|
thinkingType:
|
||||||
thinkingConfig.type as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
thinkingConfig.type as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
||||||
...(thinkingConfig.type === 'enabled' && {
|
|
||||||
thinkingBudgetTokens: thinkingConfig.budgetTokens,
|
|
||||||
}),
|
|
||||||
fallback_disabled: false,
|
fallback_disabled: false,
|
||||||
request_id: (streamRequestId ??
|
request_id: (streamRequestId ??
|
||||||
'unknown') as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
'unknown') as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
||||||
@@ -2705,9 +2693,6 @@ async function* queryModel(
|
|||||||
maxOutputTokens,
|
maxOutputTokens,
|
||||||
thinkingType:
|
thinkingType:
|
||||||
thinkingConfig.type as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
thinkingConfig.type as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
||||||
...(thinkingConfig.type === 'enabled' && {
|
|
||||||
thinkingBudgetTokens: thinkingConfig.budgetTokens,
|
|
||||||
}),
|
|
||||||
request_id:
|
request_id:
|
||||||
failedRequestId as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
failedRequestId as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
||||||
fallback_cause:
|
fallback_cause:
|
||||||
@@ -2940,7 +2925,6 @@ async function* queryModel(
|
|||||||
endTime: new Date(),
|
endTime: new Date(),
|
||||||
completionStartTime: ttftMs > 0 ? new Date(start + ttftMs) : undefined,
|
completionStartTime: ttftMs > 0 ? new Date(start + ttftMs) : undefined,
|
||||||
tools: convertToolsToLangfuse(toolSchemas as unknown[]),
|
tools: convertToolsToLangfuse(toolSchemas as unknown[]),
|
||||||
thinking: langfuseThinking,
|
|
||||||
})
|
})
|
||||||
|
|
||||||
void options.getToolPermissionContext().then(permissionContext => {
|
void options.getToolPermissionContext().then(permissionContext => {
|
||||||
|
|||||||
@@ -193,15 +193,6 @@ export async function* queryModelGemini(
|
|||||||
endTime: new Date(),
|
endTime: new Date(),
|
||||||
completionStartTime: ttftMs > 0 ? new Date(start + ttftMs) : undefined,
|
completionStartTime: ttftMs > 0 ? new Date(start + ttftMs) : undefined,
|
||||||
tools: convertToolsToLangfuse(toolSchemas as unknown[]),
|
tools: convertToolsToLangfuse(toolSchemas as unknown[]),
|
||||||
thinking:
|
|
||||||
thinkingConfig.type !== 'disabled'
|
|
||||||
? {
|
|
||||||
type: thinkingConfig.type,
|
|
||||||
...(thinkingConfig.type === 'enabled' && {
|
|
||||||
budgetTokens: thinkingConfig.budgetTokens,
|
|
||||||
}),
|
|
||||||
}
|
|
||||||
: undefined,
|
|
||||||
})
|
})
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
const errorMessage = error instanceof Error ? error.message : String(error)
|
const errorMessage = error instanceof Error ? error.message : String(error)
|
||||||
|
|||||||
@@ -23,7 +23,6 @@ import { getAPIProviderForStatsig } from 'src/utils/model/providers.js'
|
|||||||
import type { PermissionMode } from 'src/utils/permissions/PermissionMode.js'
|
import type { PermissionMode } from 'src/utils/permissions/PermissionMode.js'
|
||||||
import { jsonStringify } from 'src/utils/slowOperations.js'
|
import { jsonStringify } from 'src/utils/slowOperations.js'
|
||||||
import { logOTelEvent } from 'src/utils/telemetry/events.js'
|
import { logOTelEvent } from 'src/utils/telemetry/events.js'
|
||||||
import type { ThinkingConfig } from 'src/utils/thinking.js'
|
|
||||||
import {
|
import {
|
||||||
endLLMRequestSpan,
|
endLLMRequestSpan,
|
||||||
isBetaTracingEnabled,
|
isBetaTracingEnabled,
|
||||||
@@ -177,7 +176,7 @@ export function logAPIQuery({
|
|||||||
permissionMode,
|
permissionMode,
|
||||||
querySource,
|
querySource,
|
||||||
queryTracking,
|
queryTracking,
|
||||||
thinkingConfig,
|
thinkingType,
|
||||||
effortValue,
|
effortValue,
|
||||||
fastMode,
|
fastMode,
|
||||||
previousRequestId,
|
previousRequestId,
|
||||||
@@ -189,13 +188,11 @@ export function logAPIQuery({
|
|||||||
permissionMode?: PermissionMode
|
permissionMode?: PermissionMode
|
||||||
querySource: string
|
querySource: string
|
||||||
queryTracking?: QueryChainTracking
|
queryTracking?: QueryChainTracking
|
||||||
thinkingConfig?: ThinkingConfig
|
thinkingType?: 'adaptive' | 'enabled' | 'disabled'
|
||||||
effortValue?: EffortLevel | null
|
effortValue?: EffortLevel | null
|
||||||
fastMode?: boolean
|
fastMode?: boolean
|
||||||
previousRequestId?: string | null
|
previousRequestId?: string | null
|
||||||
}): void {
|
}): void {
|
||||||
const thinkingType = thinkingConfig?.type ?? 'disabled'
|
|
||||||
const thinkingBudgetTokens = thinkingConfig?.type === 'enabled' ? thinkingConfig.budgetTokens : undefined
|
|
||||||
logEvent('tengu_api_query', {
|
logEvent('tengu_api_query', {
|
||||||
model: model as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
model: model as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
||||||
messagesLength,
|
messagesLength,
|
||||||
@@ -222,9 +219,6 @@ export function logAPIQuery({
|
|||||||
: {}),
|
: {}),
|
||||||
thinkingType:
|
thinkingType:
|
||||||
thinkingType as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
thinkingType as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
||||||
...(thinkingBudgetTokens !== undefined && {
|
|
||||||
thinkingBudgetTokens,
|
|
||||||
}),
|
|
||||||
effortValue:
|
effortValue:
|
||||||
effortValue as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
effortValue as AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS,
|
||||||
fastMode,
|
fastMode,
|
||||||
|
|||||||
@@ -418,7 +418,6 @@ export async function* queryModelOpenAI(
|
|||||||
endTime: new Date(),
|
endTime: new Date(),
|
||||||
completionStartTime: ttftMs > 0 ? new Date(start + ttftMs) : undefined,
|
completionStartTime: ttftMs > 0 ? new Date(start + ttftMs) : undefined,
|
||||||
tools: convertToolsToLangfuse(toolSchemas as unknown[]),
|
tools: convertToolsToLangfuse(toolSchemas as unknown[]),
|
||||||
...(enableThinking && { thinking: { type: 'enabled' } }),
|
|
||||||
})
|
})
|
||||||
|
|
||||||
// Safety: if stream ended without message_stop, assemble and yield whatever we have
|
// Safety: if stream ended without message_stop, assemble and yield whatever we have
|
||||||
|
|||||||
@@ -78,16 +78,6 @@ export function recordLLMObservation(
|
|||||||
endTime?: Date
|
endTime?: Date
|
||||||
completionStartTime?: Date
|
completionStartTime?: Date
|
||||||
tools?: unknown
|
tools?: unknown
|
||||||
/** Thinking depth configuration used for this request.
|
|
||||||
* Accepts the full API thinking config object. Fields:
|
|
||||||
* - type: thinking mode ("enabled", "adaptive", "disabled")
|
|
||||||
* - budget_tokens (snake_case, from Anthropic API) or budgetTokens (camelCase)
|
|
||||||
*/
|
|
||||||
thinking?: {
|
|
||||||
type: string
|
|
||||||
budget_tokens?: number
|
|
||||||
budgetTokens?: number
|
|
||||||
}
|
|
||||||
},
|
},
|
||||||
): void {
|
): void {
|
||||||
if (!rootSpan || !isLangfuseEnabled()) return
|
if (!rootSpan || !isLangfuseEnabled()) return
|
||||||
@@ -107,7 +97,6 @@ export function recordLLMObservation(
|
|||||||
metadata: {
|
metadata: {
|
||||||
provider: params.provider,
|
provider: params.provider,
|
||||||
model: params.model,
|
model: params.model,
|
||||||
...(params.thinking && { thinking: params.thinking }),
|
|
||||||
},
|
},
|
||||||
...(params.completionStartTime && { completionStartTime: params.completionStartTime }),
|
...(params.completionStartTime && { completionStartTime: params.completionStartTime }),
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -354,7 +354,6 @@ export async function countTokensViaHaikuFallback(
|
|||||||
},
|
},
|
||||||
startTime: new Date(apiStart),
|
startTime: new Date(apiStart),
|
||||||
endTime: new Date(),
|
endTime: new Date(),
|
||||||
...(containsThinking && { thinking: { type: 'enabled', budgetTokens: TOKEN_COUNT_THINKING_BUDGET } }),
|
|
||||||
})
|
})
|
||||||
endTrace(langfuseTrace)
|
endTrace(langfuseTrace)
|
||||||
|
|
||||||
|
|||||||
@@ -171,6 +171,17 @@ describe('compactMailboxMessages', () => {
|
|||||||
|
|
||||||
expect(compacted).toEqual([])
|
expect(compacted).toEqual([])
|
||||||
})
|
})
|
||||||
|
|
||||||
|
test('returns an empty mailbox when all retention lanes are disabled', () => {
|
||||||
|
const compacted = compactMailboxMessages([message('unread', false)], {
|
||||||
|
maxMessages: 0,
|
||||||
|
maxReadMessages: 0,
|
||||||
|
maxUnreadProtocolMessages: 0,
|
||||||
|
maxRetainedBytes: 1_000,
|
||||||
|
})
|
||||||
|
|
||||||
|
expect(compacted).toEqual([])
|
||||||
|
})
|
||||||
})
|
})
|
||||||
|
|
||||||
describe('teammate mailbox retention', () => {
|
describe('teammate mailbox retention', () => {
|
||||||
@@ -331,6 +342,23 @@ describe('teammate mailbox retention', () => {
|
|||||||
expect(await readFile(inboxPath, 'utf-8')).toBe('{not-json')
|
expect(await readFile(inboxPath, 'utf-8')).toBe('{not-json')
|
||||||
})
|
})
|
||||||
|
|
||||||
|
test('writeToMailbox rejects when the inbox path is already a directory', async () => {
|
||||||
|
const inboxPath = getInboxPath('worker', 'alpha')
|
||||||
|
await mkdir(inboxPath, { recursive: true })
|
||||||
|
|
||||||
|
await expect(
|
||||||
|
writeToMailbox(
|
||||||
|
'worker',
|
||||||
|
{
|
||||||
|
from: 'team-lead',
|
||||||
|
text: 'new',
|
||||||
|
timestamp: new Date(5).toISOString(),
|
||||||
|
},
|
||||||
|
'alpha',
|
||||||
|
),
|
||||||
|
).rejects.toThrow()
|
||||||
|
})
|
||||||
|
|
||||||
test('readMailbox fails closed on corrupt mailbox content', async () => {
|
test('readMailbox fails closed on corrupt mailbox content', async () => {
|
||||||
const inboxPath = getInboxPath('worker', 'alpha')
|
const inboxPath = getInboxPath('worker', 'alpha')
|
||||||
await mkdir(dirname(inboxPath), { recursive: true })
|
await mkdir(dirname(inboxPath), { recursive: true })
|
||||||
|
|||||||
@@ -217,6 +217,23 @@ describe('UDS inbox retention', () => {
|
|||||||
)
|
)
|
||||||
})
|
})
|
||||||
|
|
||||||
|
test('udsClient send reports connection failures without leaking token state', async () => {
|
||||||
|
const path = socketPath('uds-client-connect-error')
|
||||||
|
const capabilityDir = join(tempConfigDir, 'messaging-capabilities')
|
||||||
|
const capabilityName = `${createHash('sha256').update(path).digest('hex')}.json`
|
||||||
|
await mkdir(capabilityDir, { recursive: true, mode: 0o700 })
|
||||||
|
await writeFile(
|
||||||
|
join(capabilityDir, capabilityName),
|
||||||
|
JSON.stringify({ socketPath: path, authToken: 'test-token' }),
|
||||||
|
'utf-8',
|
||||||
|
)
|
||||||
|
const { sendToUdsSocket } = await import('../udsClient.js')
|
||||||
|
|
||||||
|
await expect(sendToUdsSocket(path, 'hello')).rejects.toThrow(
|
||||||
|
'Failed to connect to peer',
|
||||||
|
)
|
||||||
|
})
|
||||||
|
|
||||||
test('sendUdsMessage fails closed before connecting without an auth token', async () => {
|
test('sendUdsMessage fails closed before connecting without an auth token', async () => {
|
||||||
await expect(
|
await expect(
|
||||||
sendUdsMessage(socketPath('no-auth-token'), { type: 'text', data: 'x' }),
|
sendUdsMessage(socketPath('no-auth-token'), { type: 'text', data: 'x' }),
|
||||||
|
|||||||
@@ -97,6 +97,28 @@ describe('attachUdsResponseReader', () => {
|
|||||||
expect(socket.ended).toBe(true)
|
expect(socket.ended).toBe(true)
|
||||||
})
|
})
|
||||||
|
|
||||||
|
test('continues scanning when blank and valid frames share one chunk', () => {
|
||||||
|
const socket = new FakeSocket()
|
||||||
|
let settled = false
|
||||||
|
let settledError: Error | undefined
|
||||||
|
|
||||||
|
attachUdsResponseReader(asSocket(socket), {
|
||||||
|
maxFrameBytes: 128,
|
||||||
|
onSettled: error => {
|
||||||
|
settled = true
|
||||||
|
settledError = error
|
||||||
|
},
|
||||||
|
})
|
||||||
|
|
||||||
|
socket.emitData(
|
||||||
|
Buffer.from(`\n${JSON.stringify({ type: 'response' })}\n`),
|
||||||
|
)
|
||||||
|
|
||||||
|
expect(settled).toBe(true)
|
||||||
|
expect(settledError).toBeUndefined()
|
||||||
|
expect(socket.ended).toBe(true)
|
||||||
|
})
|
||||||
|
|
||||||
test('rejects receiver error frames', () => {
|
test('rejects receiver error frames', () => {
|
||||||
const socket = new FakeSocket()
|
const socket = new FakeSocket()
|
||||||
let settledError: Error | undefined
|
let settledError: Error | undefined
|
||||||
@@ -116,6 +138,31 @@ describe('attachUdsResponseReader', () => {
|
|||||||
expect(socket.destroyed).toBe(true)
|
expect(socket.destroyed).toBe(true)
|
||||||
})
|
})
|
||||||
|
|
||||||
|
test('ignores unrelated receiver frames until a terminal response arrives', () => {
|
||||||
|
const socket = new FakeSocket()
|
||||||
|
let settled = false
|
||||||
|
let settledError: Error | undefined
|
||||||
|
|
||||||
|
attachUdsResponseReader(asSocket(socket), {
|
||||||
|
maxFrameBytes: 128,
|
||||||
|
onSettled: error => {
|
||||||
|
settled = true
|
||||||
|
settledError = error
|
||||||
|
},
|
||||||
|
})
|
||||||
|
|
||||||
|
socket.emitData(
|
||||||
|
Buffer.from(
|
||||||
|
`${JSON.stringify({ type: 'notification', data: 'queued' })}\n`,
|
||||||
|
),
|
||||||
|
)
|
||||||
|
expect(settled).toBe(false)
|
||||||
|
|
||||||
|
socket.emitData(Buffer.from(`${JSON.stringify({ type: 'response' })}\n`))
|
||||||
|
expect(settled).toBe(true)
|
||||||
|
expect(settledError).toBeUndefined()
|
||||||
|
})
|
||||||
|
|
||||||
test('uses custom socket error formatting', () => {
|
test('uses custom socket error formatting', () => {
|
||||||
const socket = new FakeSocket()
|
const socket = new FakeSocket()
|
||||||
let settledError: Error | undefined
|
let settledError: Error | undefined
|
||||||
|
|||||||
@@ -294,12 +294,6 @@ export async function sideQuery(opts: SideQueryOptions): Promise<BetaMessage> {
|
|||||||
startTime: new Date(start),
|
startTime: new Date(start),
|
||||||
endTime: new Date(),
|
endTime: new Date(),
|
||||||
...(tools && { tools: convertToolsToLangfuse(tools as unknown[]) }),
|
...(tools && { tools: convertToolsToLangfuse(tools as unknown[]) }),
|
||||||
...(thinkingConfig && thinkingConfig.type !== 'disabled' && {
|
|
||||||
thinking: {
|
|
||||||
type: thinkingConfig.type,
|
|
||||||
...(thinkingConfig.type === 'enabled' && { budgetTokens: thinkingConfig.budget_tokens }),
|
|
||||||
},
|
|
||||||
}),
|
|
||||||
})
|
})
|
||||||
endTrace(langfuseTrace)
|
endTrace(langfuseTrace)
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user