Fix/coderabbit nits (#1259)

Browse Source

* fix: eliminate 8 as any in MCP handlers, structured output, and stream events

- Group A: Add : () => AnyObjectSchema type annotations to MCP notification
  schema constants (useIdeSelection, useIdeLogging, usePrompts, channelNotification)
- Group B: Add isStructuredOutputAttachmentMessage type guard for structured
  output attachment payloads (execAgentHook)
- Group C: Add isMessageDeltaStreamEvent type guard for message_delta
  stream event usage extraction (forkedAgent)

These as any casts also exist in the upstream CCB source — this fix provides
real type safety without changing any runtime behavior.

* feat: wire mode persona injection — Claude Soul Document distilled into system prompt

- prompts.ts: add getModePersonaSection() → injects current mode's
  systemPrompt as 'mode_persona' dynamic section (first in order,
  before operational instructions). Previously modes had systemPrompt
  fields but they were never sent to the model.
- modes/personas/claude.ts: 3KB distilled Claude persona from
  Anthropic's leaked Claude 4.5 Opus Soul Document (70KB → operational
  extract): core traits, 7 honesty principles, helpfulness/caution
  balance, collaboration stance, identity stability.
- With custom mode YAML (~/.claude/modes/claude.yaml), 7 modes total
  including the new Claude persona — fully operational at /mode claude.

Co-Authored-By: James Feng <47167674+GhostDragon124@users.noreply.github.com>

* fix: import path convention + reword persona source comment

- prompts.ts: use 'src/modes/store.js' alias instead of relative '../modes/store.js'
  to match the file's existing import convention
- claude.ts: reword JSDoc to say 'based on publicly available reference document'
  instead of 'leaked', addressing CodeRabbit review concern

...

This commit is contained in:

James F

2026-06-07 20:06:16 +08:00

committed by GitHub

parent a972ed795c

commit be0c65678d

17 changed files with 808735 additions and 41 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

BIN

dist-nosplit/vendor/audio-capture/arm64-darwin/audio-capture.node vendored Normal file

Binary file not shown.

BIN

dist-nosplit/vendor/audio-capture/arm64-linux/audio-capture.node vendored Normal file

Binary file not shown.

BIN

dist-nosplit/vendor/audio-capture/arm64-win32/audio-capture.node vendored Normal file

Binary file not shown.

BIN

dist-nosplit/vendor/audio-capture/x64-darwin/audio-capture.node vendored Normal file

Binary file not shown.

BIN

dist-nosplit/vendor/audio-capture/x64-linux/audio-capture.node vendored Normal file

Binary file not shown.

BIN

dist-nosplit/vendor/audio-capture/x64-win32/audio-capture.node vendored Normal file

Binary file not shown.

BIN

dist-nosplit/vendor/ripgrep/arm64-linux/rg vendored Executable file

Binary file not shown.