style: 完成所有文件的lint

This commit is contained in:
claude-code-best
2026-05-01 21:39:30 +08:00
parent d136872cc9
commit 6182015005
1333 changed files with 68255 additions and 77882 deletions

View File

@@ -1,5 +1,5 @@
import type { BetaUsage } from '@anthropic-ai/sdk/resources/beta/messages/messages.mjs'
import { getSdkAgentProgressSummariesEnabled } from '../../bootstrap/state.js'
import type { BetaUsage } from '@anthropic-ai/sdk/resources/beta/messages/messages.mjs';
import { getSdkAgentProgressSummariesEnabled } from '../../bootstrap/state.js';
import {
OUTPUT_FILE_TAG,
STATUS_TAG,
@@ -10,69 +10,58 @@ import {
WORKTREE_BRANCH_TAG,
WORKTREE_PATH_TAG,
WORKTREE_TAG,
} from '../../constants/xml.js'
import { abortSpeculation } from '../../services/PromptSuggestion/speculation.js'
import type { AppState } from '../../state/AppState.js'
import type { SetAppState, Task, TaskStateBase } from '../../Task.js'
import { createTaskStateBase } from '../../Task.js'
import type { Tools } from '../../Tool.js'
import { findToolByName } from '../../Tool.js'
import type { AgentToolResult } from '@claude-code-best/builtin-tools/tools/AgentTool/agentToolUtils.js'
import type { AgentDefinition } from '@claude-code-best/builtin-tools/tools/AgentTool/loadAgentsDir.js'
import { SYNTHETIC_OUTPUT_TOOL_NAME } from '@claude-code-best/builtin-tools/tools/SyntheticOutputTool/SyntheticOutputTool.js'
import { asAgentId } from '../../types/ids.js'
import type { Message } from '../../types/message.js'
import {
createAbortController,
createChildAbortController,
} from '../../utils/abortController.js'
import { registerCleanup } from '../../utils/cleanupRegistry.js'
import { getToolSearchOrReadInfo } from '../../utils/collapseReadSearch.js'
import { enqueuePendingNotification } from '../../utils/messageQueueManager.js'
import { getAgentTranscriptPath } from '../../utils/sessionStorage.js'
import {
evictTaskOutput,
getTaskOutputPath,
initTaskOutputAsSymlink,
} from '../../utils/task/diskOutput.js'
import {
PANEL_GRACE_MS,
registerTask,
updateTaskState,
} from '../../utils/task/framework.js'
import { emitTaskProgress } from '../../utils/task/sdkProgress.js'
import type { TaskState } from '../types.js'
} from '../../constants/xml.js';
import { abortSpeculation } from '../../services/PromptSuggestion/speculation.js';
import type { AppState } from '../../state/AppState.js';
import type { SetAppState, Task, TaskStateBase } from '../../Task.js';
import { createTaskStateBase } from '../../Task.js';
import type { Tools } from '../../Tool.js';
import { findToolByName } from '../../Tool.js';
import type { AgentToolResult } from '@claude-code-best/builtin-tools/tools/AgentTool/agentToolUtils.js';
import type { AgentDefinition } from '@claude-code-best/builtin-tools/tools/AgentTool/loadAgentsDir.js';
import { SYNTHETIC_OUTPUT_TOOL_NAME } from '@claude-code-best/builtin-tools/tools/SyntheticOutputTool/SyntheticOutputTool.js';
import { asAgentId } from '../../types/ids.js';
import type { Message } from '../../types/message.js';
import { createAbortController, createChildAbortController } from '../../utils/abortController.js';
import { registerCleanup } from '../../utils/cleanupRegistry.js';
import { getToolSearchOrReadInfo } from '../../utils/collapseReadSearch.js';
import { enqueuePendingNotification } from '../../utils/messageQueueManager.js';
import { getAgentTranscriptPath } from '../../utils/sessionStorage.js';
import { evictTaskOutput, getTaskOutputPath, initTaskOutputAsSymlink } from '../../utils/task/diskOutput.js';
import { PANEL_GRACE_MS, registerTask, updateTaskState } from '../../utils/task/framework.js';
import { emitTaskProgress } from '../../utils/task/sdkProgress.js';
import type { TaskState } from '../types.js';
export type ToolActivity = {
toolName: string
input: Record<string, unknown>
toolName: string;
input: Record<string, unknown>;
/** Pre-computed activity description from the tool, e.g. "Reading src/foo.ts" */
activityDescription?: string
activityDescription?: string;
/** Pre-computed: true if this is a search operation (Grep, Glob, etc.) */
isSearch?: boolean
isSearch?: boolean;
/** Pre-computed: true if this is a read operation (Read, cat, etc.) */
isRead?: boolean
}
isRead?: boolean;
};
export type AgentProgress = {
toolUseCount: number
tokenCount: number
lastActivity?: ToolActivity
recentActivities?: ToolActivity[]
summary?: string
}
toolUseCount: number;
tokenCount: number;
lastActivity?: ToolActivity;
recentActivities?: ToolActivity[];
summary?: string;
};
const MAX_RECENT_ACTIVITIES = 5
const MAX_RECENT_ACTIVITIES = 5;
export type ProgressTracker = {
toolUseCount: number
toolUseCount: number;
// Track input and output separately to avoid double-counting.
// input_tokens in Claude API is cumulative per turn (includes all previous context),
// so we keep the latest value. output_tokens is per-turn, so we sum those.
latestInputTokens: number
cumulativeOutputTokens: number
recentActivities: ToolActivity[]
}
latestInputTokens: number;
cumulativeOutputTokens: number;
recentActivities: ToolActivity[];
};
export function createProgressTracker(): ProgressTracker {
return {
@@ -80,11 +69,11 @@ export function createProgressTracker(): ProgressTracker {
latestInputTokens: 0,
cumulativeOutputTokens: 0,
recentActivities: [],
}
};
}
export function getTokenCountFromTracker(tracker: ProgressTracker): number {
return tracker.latestInputTokens + tracker.cumulativeOutputTokens
return tracker.latestInputTokens + tracker.cumulativeOutputTokens;
}
/**
@@ -92,10 +81,7 @@ export function getTokenCountFromTracker(tracker: ProgressTracker): number {
* for a given tool name and input. Used to pre-compute descriptions
* from Tool.getActivityDescription() at recording time.
*/
export type ActivityDescriptionResolver = (
toolName: string,
input: Record<string, unknown>,
) => string | undefined
export type ActivityDescriptionResolver = (toolName: string, input: Record<string, unknown>) => string | undefined;
export function updateProgressFromMessage(
tracker: ProgressTracker,
@@ -104,42 +90,35 @@ export function updateProgressFromMessage(
tools?: Tools,
): void {
if (message.type !== 'assistant') {
return
return;
}
const usage = message.message!.usage as BetaUsage | undefined
const usage = message.message!.usage as BetaUsage | undefined;
if (!usage) {
return
return;
}
// Keep latest input (it's cumulative in the API), sum outputs
tracker.latestInputTokens =
(usage.input_tokens as number) +
(usage.cache_creation_input_tokens ?? 0) +
(usage.cache_read_input_tokens ?? 0)
tracker.cumulativeOutputTokens += usage.output_tokens as number
(usage.input_tokens as number) + (usage.cache_creation_input_tokens ?? 0) + (usage.cache_read_input_tokens ?? 0);
tracker.cumulativeOutputTokens += usage.output_tokens as number;
for (const content of (message.message!.content ?? []) as Array<{ type: string; name?: string; input?: unknown }>) {
if (content.type === 'tool_use') {
tracker.toolUseCount++
tracker.toolUseCount++;
// Omit StructuredOutput from preview - it's an internal tool
if (content.name !== SYNTHETIC_OUTPUT_TOOL_NAME) {
const input = content.input as Record<string, unknown>
const classification = tools
? getToolSearchOrReadInfo(content.name!, input, tools)
: undefined
const input = content.input as Record<string, unknown>;
const classification = tools ? getToolSearchOrReadInfo(content.name!, input, tools) : undefined;
tracker.recentActivities.push({
toolName: content.name!,
input,
activityDescription: resolveActivityDescription?.(
content.name!,
input,
),
activityDescription: resolveActivityDescription?.(content.name!, input),
isSearch: classification?.isSearch,
isRead: classification?.isRead,
})
});
}
}
}
while (tracker.recentActivities.length > MAX_RECENT_ACTIVITIES) {
tracker.recentActivities.shift()
tracker.recentActivities.shift();
}
}
@@ -148,67 +127,58 @@ export function getProgressUpdate(tracker: ProgressTracker): AgentProgress {
toolUseCount: tracker.toolUseCount,
tokenCount: getTokenCountFromTracker(tracker),
lastActivity:
tracker.recentActivities.length > 0
? tracker.recentActivities[tracker.recentActivities.length - 1]
: undefined,
tracker.recentActivities.length > 0 ? tracker.recentActivities[tracker.recentActivities.length - 1] : undefined,
recentActivities: [...tracker.recentActivities],
}
};
}
/**
* Creates an ActivityDescriptionResolver from a tools list.
* Looks up the tool by name and calls getActivityDescription if available.
*/
export function createActivityDescriptionResolver(
tools: Tools,
): ActivityDescriptionResolver {
export function createActivityDescriptionResolver(tools: Tools): ActivityDescriptionResolver {
return (toolName, input) => {
const tool = findToolByName(tools, toolName)
return tool?.getActivityDescription?.(input) ?? undefined
}
const tool = findToolByName(tools, toolName);
return tool?.getActivityDescription?.(input) ?? undefined;
};
}
export type LocalAgentTaskState = TaskStateBase & {
type: 'local_agent'
agentId: string
prompt: string
selectedAgent?: AgentDefinition
agentType: string
model?: string
abortController?: AbortController
unregisterCleanup?: () => void
error?: string
result?: AgentToolResult
progress?: AgentProgress
retrieved: boolean
messages?: Message[]
type: 'local_agent';
agentId: string;
prompt: string;
selectedAgent?: AgentDefinition;
agentType: string;
model?: string;
abortController?: AbortController;
unregisterCleanup?: () => void;
error?: string;
result?: AgentToolResult;
progress?: AgentProgress;
retrieved: boolean;
messages?: Message[];
// Track what we last reported for computing deltas
lastReportedToolCount: number
lastReportedTokenCount: number
lastReportedToolCount: number;
lastReportedTokenCount: number;
// Whether the task has been backgrounded (false = foreground running, true = backgrounded)
isBackgrounded: boolean
isBackgrounded: boolean;
// Messages queued mid-turn via SendMessage, drained at tool-round boundaries
pendingMessages: string[]
pendingMessages: string[];
// UI is holding this task: blocks eviction, enables stream-append, triggers
// disk bootstrap. Set by enterTeammateView. Separate from viewingAgentTaskId
// (which is "what am I LOOKING at") — retain is "what am I HOLDING."
retain: boolean
retain: boolean;
// Bootstrap has read the sidechain JSONL and UUID-merged into messages.
// One-shot per retain cycle; stream appends from there.
diskLoaded: boolean
diskLoaded: boolean;
// Panel visibility deadline. undefined = no deadline (running or retained);
// timestamp = hide + GC-eligible after this time. Set at terminal transition
// and on unselect; cleared on retain.
evictAfter?: number
}
evictAfter?: number;
};
export function isLocalAgentTask(task: unknown): task is LocalAgentTaskState {
return (
typeof task === 'object' &&
task !== null &&
'type' in task &&
task.type === 'local_agent'
)
return typeof task === 'object' && task !== null && 'type' in task && task.type === 'local_agent';
}
/**
@@ -218,7 +188,7 @@ export function isLocalAgentTask(task: unknown): task is LocalAgentTaskState {
* the gate changes, change it here.
*/
export function isPanelAgentTask(t: unknown): t is LocalAgentTaskState {
return isLocalAgentTask(t) && t.agentType !== 'main-session'
return isLocalAgentTask(t) && t.agentType !== 'main-session';
}
export function queuePendingMessage(
@@ -229,7 +199,7 @@ export function queuePendingMessage(
updateTaskState<LocalAgentTaskState>(taskId, setAppState, task => ({
...task,
pendingMessages: [...task.pendingMessages, msg],
}))
}));
}
/**
@@ -246,7 +216,7 @@ export function appendMessageToLocalAgent(
updateTaskState<LocalAgentTaskState>(taskId, setAppState, task => ({
...task,
messages: [...(task.messages ?? []), message],
}))
}));
}
export function drainPendingMessages(
@@ -254,16 +224,16 @@ export function drainPendingMessages(
getAppState: () => AppState,
setAppState: (f: (prev: AppState) => AppState) => void,
): string[] {
const task = getAppState().tasks[taskId]
const task = getAppState().tasks[taskId];
if (!isLocalAgentTask(task) || task.pendingMessages.length === 0) {
return []
return [];
}
const drained = task.pendingMessages
const drained = task.pendingMessages;
updateTaskState<LocalAgentTaskState>(taskId, setAppState, t => ({
...t,
pendingMessages: [],
}))
return drained
}));
return drained;
}
/**
@@ -281,72 +251,70 @@ export function enqueueAgentNotification({
worktreePath,
worktreeBranch,
}: {
taskId: string
description: string
status: 'completed' | 'failed' | 'killed'
error?: string
setAppState: SetAppState
finalMessage?: string
taskId: string;
description: string;
status: 'completed' | 'failed' | 'killed';
error?: string;
setAppState: SetAppState;
finalMessage?: string;
usage?: {
totalTokens: number
toolUses: number
durationMs: number
}
toolUseId?: string
worktreePath?: string
worktreeBranch?: string
totalTokens: number;
toolUses: number;
durationMs: number;
};
toolUseId?: string;
worktreePath?: string;
worktreeBranch?: string;
}): void {
// Atomically check and set notified flag to prevent duplicate notifications.
// If the task was already marked as notified (e.g., by TaskStopTool), skip
// enqueueing to avoid sending redundant messages to the model.
let shouldEnqueue = false
let shouldEnqueue = false;
updateTaskState<LocalAgentTaskState>(taskId, setAppState, task => {
if (task.notified) {
return task
return task;
}
shouldEnqueue = true
shouldEnqueue = true;
return {
...task,
notified: true,
}
})
};
});
if (!shouldEnqueue) {
return
return;
}
// Abort any active speculation — background task state changed, so speculated
// results may reference stale task output. The prompt suggestion text is
// preserved; only the pre-computed response is discarded.
abortSpeculation(setAppState)
abortSpeculation(setAppState);
const summary =
status === 'completed'
? `Agent "${description}" completed`
: status === 'failed'
? `Agent "${description}" failed: ${error || 'Unknown error'}`
: `Agent "${description}" was stopped`
: `Agent "${description}" was stopped`;
const outputPath = getTaskOutputPath(taskId)
const toolUseIdLine = toolUseId
? `\n<${TOOL_USE_ID_TAG}>${toolUseId}</${TOOL_USE_ID_TAG}>`
: ''
const resultSection = finalMessage ? `\n<result>${finalMessage}</result>` : ''
const outputPath = getTaskOutputPath(taskId);
const toolUseIdLine = toolUseId ? `\n<${TOOL_USE_ID_TAG}>${toolUseId}</${TOOL_USE_ID_TAG}>` : '';
const resultSection = finalMessage ? `\n<result>${finalMessage}</result>` : '';
const usageSection = usage
? `\n<usage><total_tokens>${usage.totalTokens}</total_tokens><tool_uses>${usage.toolUses}</tool_uses><duration_ms>${usage.durationMs}</duration_ms></usage>`
: ''
: '';
const worktreeSection = worktreePath
? `\n<${WORKTREE_TAG}><${WORKTREE_PATH_TAG}>${worktreePath}</${WORKTREE_PATH_TAG}>${worktreeBranch ? `<${WORKTREE_BRANCH_TAG}>${worktreeBranch}</${WORKTREE_BRANCH_TAG}>` : ''}</${WORKTREE_TAG}>`
: ''
: '';
const message = `<${TASK_NOTIFICATION_TAG}>
<${TASK_ID_TAG}>${taskId}</${TASK_ID_TAG}>${toolUseIdLine}
<${OUTPUT_FILE_TAG}>${outputPath}</${OUTPUT_FILE_TAG}>
<${STATUS_TAG}>${status}</${STATUS_TAG}>
<${SUMMARY_TAG}>${summary}</${SUMMARY_TAG}>${resultSection}${usageSection}${worktreeSection}
</${TASK_NOTIFICATION_TAG}>`
</${TASK_NOTIFICATION_TAG}>`;
enqueuePendingNotification({ value: message, mode: 'task-notification' })
enqueuePendingNotification({ value: message, mode: 'task-notification' });
}
/**
@@ -360,22 +328,22 @@ export const LocalAgentTask: Task = {
type: 'local_agent',
async kill(taskId, setAppState) {
killAsyncAgent(taskId, setAppState)
killAsyncAgent(taskId, setAppState);
},
}
};
/**
* Kill an agent task. No-op if already killed/completed.
*/
export function killAsyncAgent(taskId: string, setAppState: SetAppState): void {
let killed = false
let killed = false;
updateTaskState<LocalAgentTaskState>(taskId, setAppState, task => {
if (task.status !== 'running') {
return task
return task;
}
killed = true
task.abortController?.abort()
task.unregisterCleanup?.()
killed = true;
task.abortController?.abort();
task.unregisterCleanup?.();
return {
...task,
status: 'killed',
@@ -384,10 +352,10 @@ export function killAsyncAgent(taskId: string, setAppState: SetAppState): void {
abortController: undefined,
unregisterCleanup: undefined,
selectedAgent: undefined,
}
})
};
});
if (killed) {
void evictTaskOutput(taskId)
void evictTaskOutput(taskId);
}
}
@@ -395,13 +363,10 @@ export function killAsyncAgent(taskId: string, setAppState: SetAppState): void {
* Kill all running agent tasks.
* Used by ESC cancellation in coordinator mode to stop all subagents.
*/
export function killAllRunningAgentTasks(
tasks: Record<string, TaskState>,
setAppState: SetAppState,
): void {
export function killAllRunningAgentTasks(tasks: Record<string, TaskState>, setAppState: SetAppState): void {
for (const [taskId, task] of Object.entries(tasks)) {
if (task.type === 'local_agent' && task.status === 'running') {
killAsyncAgent(taskId, setAppState)
killAsyncAgent(taskId, setAppState);
}
}
}
@@ -411,19 +376,16 @@ export function killAllRunningAgentTasks(
* Used by chat:killAgents bulk kill to suppress per-agent async notifications
* when a single aggregate message is sent instead.
*/
export function markAgentsNotified(
taskId: string,
setAppState: SetAppState,
): void {
export function markAgentsNotified(taskId: string, setAppState: SetAppState): void {
updateTaskState<LocalAgentTaskState>(taskId, setAppState, task => {
if (task.notified) {
return task
return task;
}
return {
...task,
notified: true,
}
})
};
});
}
/**
@@ -431,45 +393,35 @@ export function markAgentsNotified(
* Preserves the existing summary field so that background summarization
* results are not clobbered by progress updates from assistant messages.
*/
export function updateAgentProgress(
taskId: string,
progress: AgentProgress,
setAppState: SetAppState,
): void {
export function updateAgentProgress(taskId: string, progress: AgentProgress, setAppState: SetAppState): void {
updateTaskState<LocalAgentTaskState>(taskId, setAppState, task => {
if (task.status !== 'running') {
return task
return task;
}
const existingSummary = task.progress?.summary
const existingSummary = task.progress?.summary;
return {
...task,
progress: existingSummary
? { ...progress, summary: existingSummary }
: progress,
}
})
progress: existingSummary ? { ...progress, summary: existingSummary } : progress,
};
});
}
/**
* Update the background summary for an agent task.
* Called by the periodic summarization service to store a 1-2 sentence progress summary.
*/
export function updateAgentSummary(
taskId: string,
summary: string,
setAppState: SetAppState,
): void {
export function updateAgentSummary(taskId: string, summary: string, setAppState: SetAppState): void {
let captured: {
tokenCount: number
toolUseCount: number
startTime: number
toolUseId: string | undefined
} | null = null
tokenCount: number;
toolUseCount: number;
startTime: number;
toolUseId: string | undefined;
} | null = null;
updateTaskState<LocalAgentTaskState>(taskId, setAppState, task => {
if (task.status !== 'running') {
return task
return task;
}
captured = {
@@ -477,7 +429,7 @@ export function updateAgentSummary(
toolUseCount: task.progress?.toolUseCount ?? 0,
startTime: task.startTime,
toolUseId: task.toolUseId,
}
};
return {
...task,
@@ -487,14 +439,14 @@ export function updateAgentSummary(
tokenCount: task.progress?.tokenCount ?? 0,
summary,
},
}
})
};
});
// Emit summary to SDK consumers (e.g. VS Code subagent panel). No-op in TUI.
// Gate on the SDK option so coordinator-mode sessions without the flag don't
// leak summary events to consumers who didn't opt in.
if (captured && getSdkAgentProgressSummariesEnabled()) {
const { tokenCount, toolUseCount, startTime, toolUseId } = captured
const { tokenCount, toolUseCount, startTime, toolUseId } = captured;
emitTaskProgress({
taskId,
toolUseId,
@@ -503,24 +455,21 @@ export function updateAgentSummary(
totalTokens: tokenCount,
toolUses: toolUseCount,
summary,
})
});
}
}
/**
* Complete an agent task with result.
*/
export function completeAgentTask(
result: AgentToolResult,
setAppState: SetAppState,
): void {
const taskId = result.agentId
export function completeAgentTask(result: AgentToolResult, setAppState: SetAppState): void {
const taskId = result.agentId;
updateTaskState<LocalAgentTaskState>(taskId, setAppState, task => {
if (task.status !== 'running') {
return task
return task;
}
task.unregisterCleanup?.()
task.unregisterCleanup?.();
return {
...task,
@@ -531,26 +480,22 @@ export function completeAgentTask(
abortController: undefined,
unregisterCleanup: undefined,
selectedAgent: undefined,
}
})
void evictTaskOutput(taskId)
};
});
void evictTaskOutput(taskId);
// Note: Notification is sent by AgentTool via enqueueAgentNotification
}
/**
* Fail an agent task with error.
*/
export function failAgentTask(
taskId: string,
error: string,
setAppState: SetAppState,
): void {
export function failAgentTask(taskId: string, error: string, setAppState: SetAppState): void {
updateTaskState<LocalAgentTaskState>(taskId, setAppState, task => {
if (task.status !== 'running') {
return task
return task;
}
task.unregisterCleanup?.()
task.unregisterCleanup?.();
return {
...task,
@@ -561,9 +506,9 @@ export function failAgentTask(
abortController: undefined,
unregisterCleanup: undefined,
selectedAgent: undefined,
}
})
void evictTaskOutput(taskId)
};
});
void evictTaskOutput(taskId);
// Note: Notification is sent by AgentTool via enqueueAgentNotification
}
@@ -584,23 +529,20 @@ export function registerAsyncAgent({
parentAbortController,
toolUseId,
}: {
agentId: string
description: string
prompt: string
selectedAgent: AgentDefinition
setAppState: SetAppState
parentAbortController?: AbortController
toolUseId?: string
agentId: string;
description: string;
prompt: string;
selectedAgent: AgentDefinition;
setAppState: SetAppState;
parentAbortController?: AbortController;
toolUseId?: string;
}): LocalAgentTaskState {
void initTaskOutputAsSymlink(
agentId,
getAgentTranscriptPath(asAgentId(agentId)),
)
void initTaskOutputAsSymlink(agentId, getAgentTranscriptPath(asAgentId(agentId)));
// Create abort controller - if parent provided, create child that auto-aborts with parent
const abortController = parentAbortController
? createChildAbortController(parentAbortController)
: createAbortController()
: createAbortController();
const taskState: LocalAgentTaskState = {
...createTaskStateBase(agentId, 'local_agent', description, toolUseId),
@@ -618,24 +560,24 @@ export function registerAsyncAgent({
pendingMessages: [],
retain: false,
diskLoaded: false,
}
};
// Register cleanup handler
const unregisterCleanup = registerCleanup(async () => {
killAsyncAgent(agentId, setAppState)
})
killAsyncAgent(agentId, setAppState);
});
taskState.unregisterCleanup = unregisterCleanup
taskState.unregisterCleanup = unregisterCleanup;
// Register task in AppState
registerTask(taskState, setAppState)
registerTask(taskState, setAppState);
return taskState
return taskState;
}
// Map of taskId -> resolve function for background signals
// When backgroundAgentTask is called, it resolves the corresponding promise
const backgroundSignalResolvers = new Map<string, () => void>()
const backgroundSignalResolvers = new Map<string, () => void>();
/**
* Register a foreground agent task that could be backgrounded later.
@@ -651,28 +593,25 @@ export function registerAgentForeground({
autoBackgroundMs,
toolUseId,
}: {
agentId: string
description: string
prompt: string
selectedAgent: AgentDefinition
setAppState: SetAppState
autoBackgroundMs?: number
toolUseId?: string
agentId: string;
description: string;
prompt: string;
selectedAgent: AgentDefinition;
setAppState: SetAppState;
autoBackgroundMs?: number;
toolUseId?: string;
}): {
taskId: string
backgroundSignal: Promise<void>
cancelAutoBackground?: () => void
taskId: string;
backgroundSignal: Promise<void>;
cancelAutoBackground?: () => void;
} {
void initTaskOutputAsSymlink(
agentId,
getAgentTranscriptPath(asAgentId(agentId)),
)
void initTaskOutputAsSymlink(agentId, getAgentTranscriptPath(asAgentId(agentId)));
const abortController = createAbortController()
const abortController = createAbortController();
const unregisterCleanup = registerCleanup(async () => {
killAsyncAgent(agentId, setAppState)
})
killAsyncAgent(agentId, setAppState);
});
const taskState: LocalAgentTaskState = {
...createTaskStateBase(agentId, 'local_agent', description, toolUseId),
@@ -691,27 +630,27 @@ export function registerAgentForeground({
pendingMessages: [],
retain: false,
diskLoaded: false,
}
};
// Create background signal promise
let resolveBackgroundSignal: () => void
let resolveBackgroundSignal: () => void;
const backgroundSignal = new Promise<void>(resolve => {
resolveBackgroundSignal = resolve
})
backgroundSignalResolvers.set(agentId, resolveBackgroundSignal!)
resolveBackgroundSignal = resolve;
});
backgroundSignalResolvers.set(agentId, resolveBackgroundSignal!);
registerTask(taskState, setAppState)
registerTask(taskState, setAppState);
// Auto-background after timeout if configured
let cancelAutoBackground: (() => void) | undefined
let cancelAutoBackground: (() => void) | undefined;
if (autoBackgroundMs !== undefined && autoBackgroundMs > 0) {
const timer = setTimeout(
(setAppState, agentId) => {
// Mark task as backgrounded and resolve the signal
setAppState(prev => {
const prevTask = prev.tasks[agentId]
const prevTask = prev.tasks[agentId];
if (!isLocalAgentTask(prevTask) || prevTask.isBackgrounded) {
return prev
return prev;
}
return {
...prev,
@@ -719,44 +658,40 @@ export function registerAgentForeground({
...prev.tasks,
[agentId]: { ...prevTask, isBackgrounded: true },
},
}
})
const resolver = backgroundSignalResolvers.get(agentId)
};
});
const resolver = backgroundSignalResolvers.get(agentId);
if (resolver) {
resolver()
backgroundSignalResolvers.delete(agentId)
resolver();
backgroundSignalResolvers.delete(agentId);
}
},
autoBackgroundMs,
setAppState,
agentId,
)
cancelAutoBackground = () => clearTimeout(timer)
);
cancelAutoBackground = () => clearTimeout(timer);
}
return { taskId: agentId, backgroundSignal, cancelAutoBackground }
return { taskId: agentId, backgroundSignal, cancelAutoBackground };
}
/**
* Background a specific foreground agent task.
* @returns true if backgrounded successfully, false otherwise
*/
export function backgroundAgentTask(
taskId: string,
getAppState: () => AppState,
setAppState: SetAppState,
): boolean {
const state = getAppState()
const task = state.tasks[taskId]
export function backgroundAgentTask(taskId: string, getAppState: () => AppState, setAppState: SetAppState): boolean {
const state = getAppState();
const task = state.tasks[taskId];
if (!isLocalAgentTask(task) || task.isBackgrounded) {
return false
return false;
}
// Update state to mark as backgrounded
setAppState(prev => {
const prevTask = prev.tasks[taskId]
const prevTask = prev.tasks[taskId];
if (!isLocalAgentTask(prevTask)) {
return prev
return prev;
}
return {
...prev,
@@ -764,45 +699,42 @@ export function backgroundAgentTask(
...prev.tasks,
[taskId]: { ...prevTask, isBackgrounded: true },
},
}
})
};
});
// Resolve the background signal to interrupt the agent loop
const resolver = backgroundSignalResolvers.get(taskId)
const resolver = backgroundSignalResolvers.get(taskId);
if (resolver) {
resolver()
backgroundSignalResolvers.delete(taskId)
resolver();
backgroundSignalResolvers.delete(taskId);
}
return true
return true;
}
/**
* Unregister a foreground agent task when the agent completes without being backgrounded.
*/
export function unregisterAgentForeground(
taskId: string,
setAppState: SetAppState,
): void {
export function unregisterAgentForeground(taskId: string, setAppState: SetAppState): void {
// Clean up the background signal resolver
backgroundSignalResolvers.delete(taskId)
backgroundSignalResolvers.delete(taskId);
let cleanupFn: (() => void) | undefined
let cleanupFn: (() => void) | undefined;
setAppState(prev => {
const task = prev.tasks[taskId]
const task = prev.tasks[taskId];
// Only remove if it's a foreground task (not backgrounded)
if (!isLocalAgentTask(task) || task.isBackgrounded) {
return prev
return prev;
}
// Capture cleanup function to call outside of updater
cleanupFn = task.unregisterCleanup
cleanupFn = task.unregisterCleanup;
const { [taskId]: removed, ...rest } = prev.tasks
return { ...prev, tasks: rest }
})
const { [taskId]: removed, ...rest } = prev.tasks;
return { ...prev, tasks: rest };
});
// Call cleanup outside of the state updater (avoid side effects in updater)
cleanupFn?.()
cleanupFn?.();
}