feat: /goal命令能力支持，参考codex实现 (#1261)

* feat: /goal命令能力支持，参考codex实现 * fix: 修复promp和提示词不一致的问题 * fix: 修复 goal 功能多项 AI 审查问题 - prompt 中 update 行为描述与运行时不一致（no-op → error） - src/commands/goal/ 使用相对路径导入，改为 src/* 别名 - /goal 命令标记 bridgeSafe 但含交互式对话框，改为 false - useGoalContinuation 中 origin 使用 as unknown as string 强转，改为直接传字符串 - ResumeConversation 路径缺少 goal hydration，补齐恢复逻辑 - onCancel 在非查询状态下误暂停 goal，加 queryGuard 守卫 - resumeGoal 允许从终态恢复，收紧为仅允许 paused 状态 - buildGoalContextBlock 生成畸形 XML 属性，改为合法 budget 属性 * fix: 修复剩余AI审查的问题 * fix: 防止goal状态丢失 * fix: 修复Biome规范错误问题 * fix: 修复部分情况下goal无法启动的问题 * fix: 增加断网后状态默认设置为PAUSE机制、完成暂停-恢复状态切换，且正常进行前端渲染。设置达到max turn后处理逻辑。 * fix: 修复终端异常断开情况，resume续跑；修复用户消息排队信息被goal输出信息覆盖的问题。 * fix: apply biome formatting to pass CI lint check Co-authored-by: Cursor <cursoragent@cursor.com> * fix: skip slash command echo in setUserInputOnProcessing to prevent UI flash Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: moyu <moyu@kingsoft.com> Co-authored-by: Cursor <cursoragent@cursor.com>
2026-06-15 12:55:51 +00:00 · 2026-06-14 10:44:10 +08:00
parent 5bfe6fa590
commit 3e3e1de81b
28 changed files with 2248 additions and 30 deletions
--- a/tests/integration/goal-lifecycle.test.ts
+++ b/tests/integration/goal-lifecycle.test.ts
@@ -0,0 +1,289 @@
+/**
+ * Integration test for the goal lifecycle.
+ * Verifies set → work → complete flow, pause/resume, budget limiting,
+ * blocked attempts, prompt generation, and audit rules consistency.
+ */
+import { beforeEach, describe, expect, mock, test } from 'bun:test'
+
+import { logMock } from '../mocks/log.js'
+mock.module('src/utils/log.ts', logMock)
+
+mock.module('bun:bundle', () => ({
+  feature: () => true,
+}))
+
+import {
+  setGoal,
+  getGoal,
+  clearGoal,
+  pauseGoal,
+  resumeGoal,
+  completeGoal,
+  updateGoalTokens,
+  markUsageLimited,
+  incrementGoalTurns,
+  recordBlockedAttempt,
+  formatGoalElapsed,
+  formatGoalStatusLabel,
+  getActiveElapsedMs,
+  _clearAllGoalsForTesting,
+  BLOCKED_CONSECUTIVE_THRESHOLD,
+  MAX_GOAL_TURNS,
+} from '../../src/services/goal/goalState'
+
+import {
+  buildContinuationPrompt,
+  buildBudgetLimitPrompt,
+  buildObjectiveUpdatedPrompt,
+  buildGoalContextBlock,
+} from '../../src/services/goal/prompts'
+
+import {
+  COMPLETION_AUDIT_RULES,
+  BLOCKED_AUDIT_RULES,
+  isGoalTerminal,
+} from '../../src/services/goal/goalAudit'
+
+const TEST_SESSION = 'test-integration-session'
+
+beforeEach(() => {
+  _clearAllGoalsForTesting()
+})
+
+describe('Goal lifecycle: set → work → complete', () => {
+  test('full happy path', () => {
+    const goal = setGoal('Implement feature X with tests', {
+      tokenBudget: 100_000,
+      sessionId: TEST_SESSION,
+    })
+    expect(goal.status).toBe('active')
+    expect(goal.objective).toBe('Implement feature X with tests')
+    expect(goal.tokenBudget).toBe(100_000)
+    expect(goal.tokensUsed).toBe(0)
+    expect(goal.turnsExecuted).toBe(0)
+
+    updateGoalTokens(15_000, TEST_SESSION)
+    incrementGoalTurns(TEST_SESSION)
+    updateGoalTokens(20_000, TEST_SESSION)
+    incrementGoalTurns(TEST_SESSION)
+
+    const mid = getGoal(TEST_SESSION)!
+    expect(mid.tokensUsed).toBe(35_000)
+    expect(mid.turnsExecuted).toBe(2)
+    expect(mid.status).toBe('active')
+
+    const completed = completeGoal(TEST_SESSION)!
+    expect(completed.status).toBe('complete')
+    expect(completed.tokensUsed).toBe(35_000)
+
+    expect(getGoal(TEST_SESSION)).not.toBeNull()
+
+    expect(clearGoal(TEST_SESSION)).toBe(true)
+    expect(getGoal(TEST_SESSION)).toBeNull()
+  })
+})
+
+describe('Goal lifecycle: pause and resume', () => {
+  test('pause accumulates active time, resume resets start', () => {
+    setGoal('Refactor module', { sessionId: TEST_SESSION })
+
+    const paused = pauseGoal(TEST_SESSION)!
+    expect(paused.status).toBe('paused')
+    expect(paused.pausedAt).not.toBeNull()
+
+    const resumed = resumeGoal(TEST_SESSION)!
+    expect(resumed.status).toBe('active')
+    expect(resumed.pausedAt).toBeNull()
+    expect(resumed.blockedAttempts).toBe(0)
+  })
+
+  test('pause on non-active goal is no-op', () => {
+    setGoal('Something', { sessionId: TEST_SESSION })
+    completeGoal(TEST_SESSION)
+    expect(pauseGoal(TEST_SESSION)).toBeNull()
+  })
+
+  test('resume on non-paused goal is no-op', () => {
+    setGoal('Something', { sessionId: TEST_SESSION })
+    expect(resumeGoal(TEST_SESSION)).toBeNull()
+  })
+})
+
+describe('Goal lifecycle: budget limiting', () => {
+  test('exceeding budget transitions to budget_limited', () => {
+    setGoal('Big task', {
+      tokenBudget: 50_000,
+      sessionId: TEST_SESSION,
+    })
+
+    updateGoalTokens(30_000, TEST_SESSION)
+    expect(getGoal(TEST_SESSION)!.status).toBe('active')
+
+    updateGoalTokens(25_000, TEST_SESSION)
+    expect(getGoal(TEST_SESSION)!.status).toBe('budget_limited')
+    expect(getGoal(TEST_SESSION)!.tokensUsed).toBe(55_000)
+  })
+
+  test('budget_limited is terminal', () => {
+    expect(isGoalTerminal('budget_limited')).toBe(true)
+  })
+})
+
+describe('Goal lifecycle: usage limiting', () => {
+  test('markUsageLimited transitions active → usage_limited', () => {
+    setGoal('Rate limited task', { sessionId: TEST_SESSION })
+    markUsageLimited(TEST_SESSION)
+    expect(getGoal(TEST_SESSION)!.status).toBe('usage_limited')
+  })
+
+  test('usage_limited is terminal', () => {
+    expect(isGoalTerminal('usage_limited')).toBe(true)
+  })
+})
+
+describe('Goal lifecycle: blocked attempts', () => {
+  test('3 consecutive same-reason attempts transition to blocked', () => {
+    setGoal('Need credentials', { sessionId: TEST_SESSION })
+
+    const r1 = recordBlockedAttempt('missing API key', TEST_SESSION)!
+    expect(r1.status).toBe('active')
+    expect(r1.attempts).toBe(1)
+
+    const r2 = recordBlockedAttempt('missing API key', TEST_SESSION)!
+    expect(r2.status).toBe('active')
+    expect(r2.attempts).toBe(2)
+
+    const r3 = recordBlockedAttempt('missing API key', TEST_SESSION)!
+    expect(r3.status).toBe('blocked')
+    expect(r3.attempts).toBe(3)
+  })
+
+  test('different reason resets counter', () => {
+    setGoal('Flaky thing', { sessionId: TEST_SESSION })
+
+    recordBlockedAttempt('error A', TEST_SESSION)
+    recordBlockedAttempt('error A', TEST_SESSION)
+    const r = recordBlockedAttempt('error B', TEST_SESSION)!
+    expect(r.status).toBe('active')
+    expect(r.attempts).toBe(1)
+  })
+
+  test('resume resets blocked attempts', () => {
+    setGoal('Was stuck', { sessionId: TEST_SESSION })
+    recordBlockedAttempt('oops', TEST_SESSION)
+    recordBlockedAttempt('oops', TEST_SESSION)
+    pauseGoal(TEST_SESSION)
+    resumeGoal(TEST_SESSION)
+    expect(getGoal(TEST_SESSION)!.blockedAttempts).toBe(0)
+  })
+
+  test('BLOCKED_CONSECUTIVE_THRESHOLD is 3', () => {
+    expect(BLOCKED_CONSECUTIVE_THRESHOLD).toBe(3)
+  })
+})
+
+describe('Goal lifecycle: turn limits', () => {
+  test('MAX_GOAL_TURNS is a reasonable upper bound', () => {
+    expect(MAX_GOAL_TURNS).toBeGreaterThanOrEqual(10)
+    expect(MAX_GOAL_TURNS).toBeLessThanOrEqual(200)
+  })
+
+  test('incrementGoalTurns counts correctly', () => {
+    setGoal('Counting', { sessionId: TEST_SESSION })
+    for (let i = 1; i <= 5; i++) {
+      expect(incrementGoalTurns(TEST_SESSION)).toBe(i)
+    }
+    expect(getGoal(TEST_SESSION)!.turnsExecuted).toBe(5)
+  })
+})
+
+describe('isGoalTerminal', () => {
+  test('active and paused are NOT terminal', () => {
+    expect(isGoalTerminal('active')).toBe(false)
+    expect(isGoalTerminal('paused')).toBe(false)
+  })
+
+  test('complete, blocked, budget_limited, usage_limited are terminal', () => {
+    expect(isGoalTerminal('complete')).toBe(true)
+    expect(isGoalTerminal('blocked')).toBe(true)
+    expect(isGoalTerminal('budget_limited')).toBe(true)
+    expect(isGoalTerminal('usage_limited')).toBe(true)
+  })
+})
+
+describe('Goal prompt templates', () => {
+  test('continuation prompt contains objective and audit rules', () => {
+    const goal = setGoal('Build dashboard', {
+      tokenBudget: 200_000,
+      sessionId: TEST_SESSION,
+    })
+    const prompt = buildContinuationPrompt(goal)
+    expect(prompt).toContain('Build dashboard')
+    expect(prompt).toContain('goal-steering')
+    expect(prompt).toContain('continuation')
+    expect(prompt).toContain('Completion Audit')
+    expect(prompt).toContain('Blocked Audit')
+    expect(prompt).toContain('200000')
+  })
+
+  test('budget limit prompt instructs stop', () => {
+    const goal = setGoal('Over budget', {
+      tokenBudget: 50_000,
+      sessionId: TEST_SESSION,
+    })
+    updateGoalTokens(60_000, TEST_SESSION)
+    const updated = getGoal(TEST_SESSION)!
+    const prompt = buildBudgetLimitPrompt(updated)
+    expect(prompt).toContain('budget_limit')
+    expect(prompt).toContain('Stop all substantive work')
+    expect(prompt).toContain('60000')
+  })
+
+  test('objective updated prompt contains new objective', () => {
+    const prompt = buildObjectiveUpdatedPrompt('New objective', 'Old objective')
+    expect(prompt).toContain('objective_updated')
+    expect(prompt).toContain('New objective')
+    expect(prompt).toContain('Old objective')
+  })
+
+  test('goal context block is compact', () => {
+    const goal = setGoal('Short task', { sessionId: TEST_SESSION })
+    const block = buildGoalContextBlock(goal)
+    expect(block).toContain('<active-goal')
+    expect(block).toContain('Short task')
+    expect(block).toContain('</active-goal>')
+    expect(block.split('\n').length).toBeLessThanOrEqual(5)
+  })
+})
+
+describe('Audit rules consistency', () => {
+  test('completion audit has 6 rules', () => {
+    expect(COMPLETION_AUDIT_RULES.length).toBe(6)
+  })
+
+  test('blocked audit has 3 rules', () => {
+    expect(BLOCKED_AUDIT_RULES.length).toBe(3)
+  })
+
+  test('continuation prompt embeds all completion audit rules', () => {
+    const goal = setGoal('Audit check', { sessionId: TEST_SESSION })
+    const prompt = buildContinuationPrompt(goal)
+    for (const rule of COMPLETION_AUDIT_RULES) {
+      expect(prompt).toContain(rule)
+    }
+  })
+})
+
+describe('Format helpers', () => {
+  test('formatGoalStatusLabel returns human-readable labels', () => {
+    expect(formatGoalStatusLabel('active')).toBe('Active')
+    expect(formatGoalStatusLabel('budget_limited')).toBe('Budget Limited')
+    expect(formatGoalStatusLabel('complete')).toBe('Complete')
+  })
+
+  test('getActiveElapsedMs returns accumulated time for paused goals', () => {
+    const goal = setGoal('Timed', { sessionId: TEST_SESSION })
+    const elapsed = getActiveElapsedMs(goal)
+    expect(elapsed).toBeGreaterThanOrEqual(0)
+  })
+})