mirror of
https://github.com/claude-code-best/claude-code.git
synced 2026-06-18 06:15:51 +00:00
test: 添加 subagent 僵死场景相关测试用例
覆盖 subagent 生命周期关键模块的零覆盖函数： - messageQueueManager: 扩展队列操作测试（enqueue/dequeue/优先级排序） - queueProcessor: 测试 subagent 通知过滤和批量处理 - LocalAgentTask: 测试状态转换、通知防重、进度追踪 - task/framework: 测试 updateTaskState、registerTask、evictTerminalTask 共 66 个测试用例，135 个断言，全部通过。 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
claude-code-best
487
src/tasks/LocalAgentTask/__tests__/LocalAgentTask.test.ts
Normal file
487
src/tasks/LocalAgentTask/__tests__/LocalAgentTask.test.ts
Normal file
@@ -0,0 +1,487 @@
|
||||
import { afterEach, describe, expect, mock, test } from 'bun:test'
|
||||
import { debugMock } from '../../../../tests/mocks/debug.js'
|
||||
import { logMock } from '../../../../tests/mocks/log.js'
|
||||
|
||||
// ─── Mocks ───
|
||||
|
||||
const noop = () => {}
|
||||
|
||||
mock.module('src/utils/debug.ts', debugMock)
|
||||
mock.module('src/utils/log.ts', logMock)
|
||||
|
||||
mock.module('src/utils/sessionStorage.js', () => ({
|
||||
getAgentTranscriptPath: (id: string) => `/tmp/transcripts/${id}.jsonl`,
|
||||
recordSidechainTranscript: async () => {},
|
||||
recordQueueOperation: noop,
|
||||
writeAgentMetadata: async () => {},
|
||||
}))
|
||||
|
||||
mock.module('src/utils/task/diskOutput.js', () => ({
|
||||
evictTaskOutput: noop,
|
||||
getTaskOutputPath: (id: string) => `/tmp/output/${id}`,
|
||||
initTaskOutputAsSymlink: async () => {},
|
||||
getTaskOutputDelta: async () => null,
|
||||
}))
|
||||
|
||||
// Capture enqueuePendingNotification calls for verification
|
||||
const enqueuedNotifications: string[] = []
|
||||
mock.module('src/utils/messageQueueManager.js', () => ({
|
||||
enqueuePendingNotification: (cmd: any) => {
|
||||
enqueuedNotifications.push(cmd.value)
|
||||
},
|
||||
}))
|
||||
|
||||
mock.module('src/bootstrap/state.js', () => ({
|
||||
getSdkAgentProgressSummariesEnabled: () => false,
|
||||
getSessionId: () => 'test-session-001',
|
||||
getProjectRoot: () => '/test/project',
|
||||
getIsNonInteractiveSession: () => false,
|
||||
addSlowOperation: noop,
|
||||
}))
|
||||
|
||||
mock.module('src/services/PromptSuggestion/speculation.js', () => ({
|
||||
abortSpeculation: noop,
|
||||
}))
|
||||
|
||||
const cleanupFns: (() => void)[] = []
|
||||
mock.module('src/utils/cleanupRegistry.js', () => ({
|
||||
registerCleanup: () => noop,
|
||||
}))
|
||||
|
||||
mock.module('src/utils/abortController.js', () => ({
|
||||
createAbortController: () => new AbortController(),
|
||||
createChildAbortController: (parent: AbortController) => {
|
||||
const ac = new AbortController()
|
||||
parent.signal.addEventListener('abort', () => ac.abort())
|
||||
return ac
|
||||
},
|
||||
}))
|
||||
|
||||
mock.module('src/utils/task/sdkProgress.js', () => ({
|
||||
emitTaskProgress: noop,
|
||||
}))
|
||||
|
||||
mock.module('src/utils/sdkEventQueue.js', () => ({
|
||||
enqueueSdkEvent: noop,
|
||||
}))
|
||||
|
||||
mock.module('src/constants/xml.js', () => ({
|
||||
TASK_NOTIFICATION_TAG: 'task_notification',
|
||||
TASK_ID_TAG: 'task_id',
|
||||
TOOL_USE_ID_TAG: 'tool_use_id',
|
||||
OUTPUT_FILE_TAG: 'output_file',
|
||||
STATUS_TAG: 'status',
|
||||
SUMMARY_TAG: 'summary',
|
||||
WORKTREE_TAG: 'worktree',
|
||||
WORKTREE_PATH_TAG: 'worktree_path',
|
||||
WORKTREE_BRANCH_TAG: 'worktree_branch',
|
||||
TASK_TYPE_TAG: 'task_type',
|
||||
}))
|
||||
|
||||
mock.module('src/services/analytics/index.js', () => ({
|
||||
logEvent: noop,
|
||||
logEventAsync: async () => {},
|
||||
stripProtoFields: (v: any) => v,
|
||||
attachAnalyticsSink: noop,
|
||||
_resetForTesting: noop,
|
||||
AnalyticsMetadata_I_VERIFIED_THIS_IS_NOT_CODE_OR_FILEPATHS: undefined,
|
||||
}))
|
||||
|
||||
mock.module('src/utils/collapseReadSearch.js', () => ({
|
||||
getToolSearchOrReadInfo: () => undefined,
|
||||
}))
|
||||
|
||||
// ─── Import after mocks ───
|
||||
|
||||
const {
|
||||
createProgressTracker,
|
||||
updateProgressFromMessage,
|
||||
getProgressUpdate,
|
||||
completeAgentTask,
|
||||
failAgentTask,
|
||||
killAsyncAgent,
|
||||
enqueueAgentNotification,
|
||||
registerAsyncAgent,
|
||||
updateAgentProgress,
|
||||
isLocalAgentTask,
|
||||
} = await import('../LocalAgentTask.js')
|
||||
|
||||
// ─── Helpers ───
|
||||
|
||||
type AppStateLike = { tasks: Record<string, any> }
|
||||
type SetAppStateLike = (f: (prev: AppStateLike) => AppStateLike) => void
|
||||
|
||||
function createSetAppState(initial: AppStateLike = { tasks: {} }): {
|
||||
setAppState: SetAppStateLike
|
||||
getState: () => AppStateLike
|
||||
} {
|
||||
let state = initial
|
||||
return {
|
||||
setAppState: (f) => {
|
||||
state = f(state)
|
||||
},
|
||||
getState: () => state,
|
||||
}
|
||||
}
|
||||
|
||||
function makeRunningTask(overrides: Record<string, any> = {}): any {
|
||||
return {
|
||||
id: 'test-agent-001',
|
||||
type: 'local_agent',
|
||||
status: 'running',
|
||||
description: 'Test agent',
|
||||
agentId: 'test-agent-001',
|
||||
prompt: 'do something',
|
||||
agentType: 'general-purpose',
|
||||
abortController: new AbortController(),
|
||||
retrieved: false,
|
||||
lastReportedToolCount: 0,
|
||||
lastReportedTokenCount: 0,
|
||||
isBackgrounded: true,
|
||||
pendingMessages: [],
|
||||
retain: false,
|
||||
diskLoaded: false,
|
||||
notified: false,
|
||||
startTime: Date.now(),
|
||||
outputFile: '/tmp/output/test-agent-001',
|
||||
outputOffset: 0,
|
||||
...overrides,
|
||||
}
|
||||
}
|
||||
|
||||
function makeAssistantMessage(usage: any, content: any[] = []): any {
|
||||
return {
|
||||
type: 'assistant',
|
||||
message: {
|
||||
usage,
|
||||
content,
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
afterEach(() => {
|
||||
enqueuedNotifications.length = 0
|
||||
})
|
||||
|
||||
// ─── Tests ───
|
||||
|
||||
describe('createProgressTracker', () => {
|
||||
test('returns initial state with zero counts', () => {
|
||||
const tracker = createProgressTracker()
|
||||
expect(tracker.toolUseCount).toBe(0)
|
||||
expect(tracker.latestInputTokens).toBe(0)
|
||||
expect(tracker.cumulativeOutputTokens).toBe(0)
|
||||
expect(tracker.recentActivities).toEqual([])
|
||||
})
|
||||
})
|
||||
|
||||
describe('updateProgressFromMessage', () => {
|
||||
test('skips non-assistant messages', () => {
|
||||
const tracker = createProgressTracker()
|
||||
updateProgressFromMessage(tracker, { type: 'user', message: {} } as any)
|
||||
expect(tracker.toolUseCount).toBe(0)
|
||||
expect(tracker.latestInputTokens).toBe(0)
|
||||
})
|
||||
|
||||
test('updates token counts from assistant message usage', () => {
|
||||
const tracker = createProgressTracker()
|
||||
const msg = makeAssistantMessage({
|
||||
input_tokens: 100,
|
||||
output_tokens: 50,
|
||||
cache_creation_input_tokens: 20,
|
||||
cache_read_input_tokens: 30,
|
||||
})
|
||||
updateProgressFromMessage(tracker, msg)
|
||||
expect(tracker.latestInputTokens).toBe(150) // 100 + 20 + 30
|
||||
expect(tracker.cumulativeOutputTokens).toBe(50)
|
||||
})
|
||||
|
||||
test('counts tool_use blocks and tracks recent activities', () => {
|
||||
const tracker = createProgressTracker()
|
||||
const msg = makeAssistantMessage({ input_tokens: 0, output_tokens: 0 }, [
|
||||
{ type: 'tool_use', name: 'Read', input: { file_path: '/foo.ts' } },
|
||||
{ type: 'text', text: 'thinking...' },
|
||||
{ type: 'tool_use', name: 'Write', input: { file_path: '/bar.ts' } },
|
||||
])
|
||||
updateProgressFromMessage(tracker, msg)
|
||||
expect(tracker.toolUseCount).toBe(2)
|
||||
expect(tracker.recentActivities).toHaveLength(2)
|
||||
expect(tracker.recentActivities[0]!.toolName).toBe('Read')
|
||||
expect(tracker.recentActivities[1]!.toolName).toBe('Write')
|
||||
})
|
||||
|
||||
test('caps recentActivities at 5', () => {
|
||||
const tracker = createProgressTracker()
|
||||
for (let i = 0; i < 7; i++) {
|
||||
const msg = makeAssistantMessage({ input_tokens: 0, output_tokens: 0 }, [
|
||||
{ type: 'tool_use', name: `Tool${i}`, input: {} },
|
||||
])
|
||||
updateProgressFromMessage(tracker, msg)
|
||||
}
|
||||
expect(tracker.recentActivities).toHaveLength(5)
|
||||
})
|
||||
|
||||
test('skips without usage', () => {
|
||||
const tracker = createProgressTracker()
|
||||
const msg = makeAssistantMessage(null)
|
||||
updateProgressFromMessage(tracker, msg)
|
||||
expect(tracker.latestInputTokens).toBe(0)
|
||||
})
|
||||
})
|
||||
|
||||
describe('getProgressUpdate', () => {
|
||||
test('returns correct progress snapshot', () => {
|
||||
const tracker = createProgressTracker()
|
||||
tracker.toolUseCount = 3
|
||||
tracker.latestInputTokens = 100
|
||||
tracker.cumulativeOutputTokens = 50
|
||||
tracker.recentActivities.push({ toolName: 'Read', input: {} })
|
||||
|
||||
const progress = getProgressUpdate(tracker)
|
||||
expect(progress.toolUseCount).toBe(3)
|
||||
expect(progress.tokenCount).toBe(150)
|
||||
expect(progress.lastActivity).toBeDefined()
|
||||
expect(progress.lastActivity!.toolName).toBe('Read')
|
||||
})
|
||||
|
||||
test('returns undefined lastActivity when no activities', () => {
|
||||
const tracker = createProgressTracker()
|
||||
const progress = getProgressUpdate(tracker)
|
||||
expect(progress.lastActivity).toBeUndefined()
|
||||
})
|
||||
})
|
||||
|
||||
describe('completeAgentTask', () => {
|
||||
test('transitions running task to completed', () => {
|
||||
const { setAppState, getState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask() },
|
||||
})
|
||||
|
||||
completeAgentTask(
|
||||
{ agentId: 'test-agent-001', content: [], totalToolUseCount: 0, totalDurationMs: 100 } as any,
|
||||
setAppState as any,
|
||||
)
|
||||
|
||||
const task = getState().tasks['test-agent-001']
|
||||
expect(task.status).toBe('completed')
|
||||
expect(task.endTime).toBeDefined()
|
||||
expect(task.evictAfter).toBeDefined()
|
||||
})
|
||||
|
||||
test('no-op if task not running', () => {
|
||||
const { setAppState, getState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask({ status: 'completed' }) },
|
||||
})
|
||||
|
||||
completeAgentTask(
|
||||
{ agentId: 'test-agent-001', content: [], totalToolUseCount: 0, totalDurationMs: 100 } as any,
|
||||
setAppState as any,
|
||||
)
|
||||
|
||||
const task = getState().tasks['test-agent-001']
|
||||
expect(task.status).toBe('completed')
|
||||
})
|
||||
})
|
||||
|
||||
describe('failAgentTask', () => {
|
||||
test('transitions running task to failed with error message', () => {
|
||||
const { setAppState, getState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask() },
|
||||
})
|
||||
|
||||
failAgentTask('test-agent-001', 'Stream idle timeout', setAppState as any)
|
||||
|
||||
const task = getState().tasks['test-agent-001']
|
||||
expect(task.status).toBe('failed')
|
||||
expect(task.error).toBe('Stream idle timeout')
|
||||
expect(task.endTime).toBeDefined()
|
||||
})
|
||||
|
||||
test('no-op if task not running', () => {
|
||||
const { setAppState, getState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask({ status: 'killed' }) },
|
||||
})
|
||||
|
||||
failAgentTask('test-agent-001', 'error', setAppState as any)
|
||||
|
||||
const task = getState().tasks['test-agent-001']
|
||||
expect(task.status).toBe('killed')
|
||||
expect(task.error).toBeUndefined()
|
||||
})
|
||||
})
|
||||
|
||||
describe('killAsyncAgent', () => {
|
||||
test('transitions running task to killed', () => {
|
||||
const ac = new AbortController()
|
||||
const cleanup = mock(() => {})
|
||||
const { setAppState, getState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask({ abortController: ac, unregisterCleanup: cleanup }) },
|
||||
})
|
||||
|
||||
killAsyncAgent('test-agent-001', setAppState as any)
|
||||
|
||||
const task = getState().tasks['test-agent-001']
|
||||
expect(task.status).toBe('killed')
|
||||
expect(ac.signal.aborted).toBe(true)
|
||||
expect(cleanup).toHaveBeenCalled()
|
||||
expect(task.abortController).toBeUndefined()
|
||||
})
|
||||
|
||||
test('no-op if task not running', () => {
|
||||
const { setAppState, getState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask({ status: 'completed' }) },
|
||||
})
|
||||
|
||||
killAsyncAgent('test-agent-001', setAppState as any)
|
||||
|
||||
const task = getState().tasks['test-agent-001']
|
||||
expect(task.status).toBe('completed')
|
||||
})
|
||||
})
|
||||
|
||||
describe('enqueueAgentNotification', () => {
|
||||
test('enqueues completed notification with correct XML format', () => {
|
||||
const { setAppState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask({ notified: false }) },
|
||||
})
|
||||
|
||||
enqueueAgentNotification({
|
||||
taskId: 'test-agent-001',
|
||||
description: 'refactor auth',
|
||||
status: 'completed',
|
||||
setAppState: setAppState as any,
|
||||
finalMessage: 'Done!',
|
||||
usage: { totalTokens: 5000, toolUses: 3, durationMs: 10000 },
|
||||
})
|
||||
|
||||
expect(enqueuedNotifications).toHaveLength(1)
|
||||
expect(enqueuedNotifications[0]).toContain('<task_notification>')
|
||||
expect(enqueuedNotifications[0]).toContain('<task_id>test-agent-001</task_id>')
|
||||
expect(enqueuedNotifications[0]).toContain('<status>completed</status>')
|
||||
expect(enqueuedNotifications[0]).toContain('Agent "refactor auth" completed')
|
||||
expect(enqueuedNotifications[0]).toContain('<result>Done!</result>')
|
||||
expect(enqueuedNotifications[0]).toContain('<total_tokens>5000</total_tokens>')
|
||||
})
|
||||
|
||||
test('enqueues failed notification with error', () => {
|
||||
const { setAppState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask({ notified: false }) },
|
||||
})
|
||||
|
||||
enqueueAgentNotification({
|
||||
taskId: 'test-agent-001',
|
||||
description: 'test',
|
||||
status: 'failed',
|
||||
error: 'Stream idle timeout',
|
||||
setAppState: setAppState as any,
|
||||
})
|
||||
|
||||
expect(enqueuedNotifications).toHaveLength(1)
|
||||
expect(enqueuedNotifications[0]).toContain('<status>failed</status>')
|
||||
expect(enqueuedNotifications[0]).toContain('Agent "test" failed: Stream idle timeout')
|
||||
})
|
||||
|
||||
test('enqueues killed notification', () => {
|
||||
const { setAppState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask({ notified: false }) },
|
||||
})
|
||||
|
||||
enqueueAgentNotification({
|
||||
taskId: 'test-agent-001',
|
||||
description: 'test',
|
||||
status: 'killed',
|
||||
setAppState: setAppState as any,
|
||||
})
|
||||
|
||||
expect(enqueuedNotifications).toHaveLength(1)
|
||||
expect(enqueuedNotifications[0]).toContain('<status>killed</status>')
|
||||
expect(enqueuedNotifications[0]).toContain('Agent "test" was stopped')
|
||||
})
|
||||
|
||||
test('prevents duplicate notifications', () => {
|
||||
const { setAppState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask({ notified: false }) },
|
||||
})
|
||||
|
||||
enqueueAgentNotification({
|
||||
taskId: 'test-agent-001',
|
||||
description: 'test',
|
||||
status: 'completed',
|
||||
setAppState: setAppState as any,
|
||||
})
|
||||
|
||||
// Second call — notified flag already set by first call
|
||||
enqueueAgentNotification({
|
||||
taskId: 'test-agent-001',
|
||||
description: 'test',
|
||||
status: 'completed',
|
||||
setAppState: setAppState as any,
|
||||
})
|
||||
|
||||
expect(enqueuedNotifications).toHaveLength(1)
|
||||
})
|
||||
|
||||
test('skips if task already notified', () => {
|
||||
const { setAppState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask({ notified: true }) },
|
||||
})
|
||||
|
||||
enqueueAgentNotification({
|
||||
taskId: 'test-agent-001',
|
||||
description: 'test',
|
||||
status: 'completed',
|
||||
setAppState: setAppState as any,
|
||||
})
|
||||
|
||||
expect(enqueuedNotifications).toHaveLength(0)
|
||||
})
|
||||
})
|
||||
|
||||
describe('isLocalAgentTask', () => {
|
||||
test('returns true for local_agent type', () => {
|
||||
expect(isLocalAgentTask(makeRunningTask())).toBe(true)
|
||||
})
|
||||
|
||||
test('returns false for other types', () => {
|
||||
expect(isLocalAgentTask({ type: 'local_bash' })).toBe(false)
|
||||
})
|
||||
|
||||
test('returns false for null/undefined', () => {
|
||||
expect(isLocalAgentTask(null)).toBe(false)
|
||||
expect(isLocalAgentTask(undefined)).toBe(false)
|
||||
})
|
||||
})
|
||||
|
||||
describe('updateAgentProgress', () => {
|
||||
test('updates progress while preserving summary', () => {
|
||||
const { setAppState, getState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask({ progress: { summary: 'Working on auth' } }) },
|
||||
})
|
||||
|
||||
updateAgentProgress(
|
||||
'test-agent-001',
|
||||
{ toolUseCount: 5, tokenCount: 1000, lastActivity: { toolName: 'Write', input: {} } },
|
||||
setAppState as any,
|
||||
)
|
||||
|
||||
const task = getState().tasks['test-agent-001']
|
||||
expect(task.progress.toolUseCount).toBe(5)
|
||||
expect(task.progress.tokenCount).toBe(1000)
|
||||
expect(task.progress.summary).toBe('Working on auth')
|
||||
})
|
||||
|
||||
test('no-op if task not running', () => {
|
||||
const { setAppState, getState } = createSetAppState({
|
||||
tasks: { 'test-agent-001': makeRunningTask({ status: 'completed', progress: {} }) },
|
||||
})
|
||||
|
||||
updateAgentProgress(
|
||||
'test-agent-001',
|
||||
{ toolUseCount: 5, tokenCount: 1000 },
|
||||
setAppState as any,
|
||||
)
|
||||
|
||||
const task = getState().tasks['test-agent-001']
|
||||
expect(task.progress.toolUseCount).toBeUndefined()
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user