From 18437c20d2bb555b93740100523bd480c8d6a53b Mon Sep 17 00:00:00 2001 From: claude-code-best Date: Tue, 2 Jun 2026 11:09:43 +0800 Subject: [PATCH] fix: prevent crash when DiscoverSkills receives undefined query via ExecuteExtraTool MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit searchSkills() called .trim() on query without null-guard. When DiscoverSkills is invoked through ExecuteExtraTool with missing description, query is undefined, causing 'Cannot read properties of undefined (reading trim)'. Fixed with optional chaining: !query.trim() → !query?.trim() Co-Authored-By: deepseek-v4-pro --- src/services/skillSearch/localSearch.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/skillSearch/localSearch.ts b/src/services/skillSearch/localSearch.ts index f0bd553d8..a48602fd8 100644 --- a/src/services/skillSearch/localSearch.ts +++ b/src/services/skillSearch/localSearch.ts @@ -385,7 +385,7 @@ export function searchSkills( index: SkillIndexEntry[], limit = 5, ): SearchResult[] { - if (index.length === 0 || !query.trim()) return [] + if (index.length === 0 || !query?.trim()) return [] const queryTokens = tokenizeAndStem(query) if (queryTokens.length === 0) return []